diff options
| author | David Chase <drchase@google.com> | 2016-11-10 16:03:47 -0500 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2017-01-09 21:01:29 +0000 |
| commit | 7f1ff65c3947b916cc4d0827fd8c1307d7efd7bf (patch) | |
| tree | a9b8ff06dd46b39671df2649f42d5b3f8551bafa /test/opt_branchlikely.go | |
| parent | f412bd31ce1859ea1dd0d46ec1b130c44b480115 (diff) | |
| download | go-7f1ff65c3947b916cc4d0827fd8c1307d7efd7bf.tar.gz go-7f1ff65c3947b916cc4d0827fd8c1307d7efd7bf.zip | |
cmd/compile: insert scheduling checks on loop backedges
Loop breaking with a counter. Benchmarked (see comments),
eyeball checked for sanity on popular loops. This code
ought to handle loops in general, and properly inserts phi
functions in cases where the earlier version might not have.
Includes test, plus modifications to test/run.go to deal with
timeout and killing looping test. Tests broken by the addition
of extra code (branch frequency and live vars) for added
checks turn the check insertion off.
If GOEXPERIMENT=preemptibleloops, the compiler inserts reschedule
checks on every backedge of every reducible loop. Alternately,
specifying GO_GCFLAGS=-d=ssa/insert_resched_checks/on will
enable it for a single compilation, but because the core Go
libraries contain some loops that may run long, this is less
likely to have the desired effect.
This is intended as a tool to help in the study and diagnosis
of GC and other latency problems, now that goal STW GC latency
is on the order of 100 microseconds or less.
Updates #17831.
Updates #10958.
Change-Id: I6206c163a5b0248e3f21eb4fc65f73a179e1f639
Reviewed-on: https://go-review.googlesource.com/33910
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'test/opt_branchlikely.go')
| -rw-r--r-- | test/opt_branchlikely.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/opt_branchlikely.go b/test/opt_branchlikely.go index 5781253e3e..84de32179f 100644 --- a/test/opt_branchlikely.go +++ b/test/opt_branchlikely.go @@ -1,5 +1,6 @@ // +build amd64 -// errorcheck -0 -d=ssa/likelyadjust/debug=1 +// errorcheck -0 -d=ssa/likelyadjust/debug=1,ssa/insert_resched_checks/off +// rescheduling check insertion is turend off because the inserted conditional branches perturb the errorcheck // Copyright 2016 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style |