diff options
| author | Russ Cox <rsc@golang.org> | 2014-08-30 00:56:52 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-08-30 00:56:52 -0400 |
| commit | 397bdb216f705a3e3221c98904237820d4950042 (patch) | |
| tree | 4bbe8e737963a97bfc27e3ddcf67b93924b8d66c /test/nosplit.go | |
| parent | 0316dafda26619175f35e5e89f1920ebf37c85a3 (diff) | |
| download | go-397bdb216f705a3e3221c98904237820d4950042.tar.gz go-397bdb216f705a3e3221c98904237820d4950042.zip | |
runtime: increase nosplit area to 192
In CL 131450043, which raised it to 160,
I'd raise it to 192 if necessary.
Apparently it is necessary on windows/amd64.
One note for those concerned about the growth:
in the old segmented stack world, we wasted this much
space at the bottom of every stack segment.
In the new contiguous stack world, each goroutine has
only one stack segment, so we only waste this much space
once per goroutine. So even raising the limit further might
still be a net savings.
Fixes windows/amd64 build.
TBR=r
CC=golang-codereviews
https://golang.org/cl/132480043
Diffstat (limited to 'test/nosplit.go')
| -rw-r--r-- | test/nosplit.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/nosplit.go b/test/nosplit.go index 39bb3fcb47..3854f24203 100644 --- a/test/nosplit.go +++ b/test/nosplit.go @@ -256,11 +256,11 @@ TestCases: name := m[1] size, _ := strconv.Atoi(m[2]) - // CL 131450043 raised the limit from 128 to 160. + // The limit was originally 128 but is now 192. // Instead of rewriting the test cases above, adjust // the first stack frame to use up the extra 32 bytes. if i == 0 { - size += 32 + size += 192 - 128 } if goarch == "amd64" && size%8 == 4 { |