diff options
| author | Clément Chigot <clement.chigot@atos.net> | 2018-10-16 15:59:43 +0200 |
|---|---|---|
| committer | Lynn Boger <laboger@linux.vnet.ibm.com> | 2018-11-26 14:13:53 +0000 |
| commit | 9fe9853ae5641eda4cfa58015bd0bcedb99c12cb (patch) | |
| tree | 7d9f5dc6ec5ab99abe48eb30c009291dabe02e5b /test/nilptr.go | |
| parent | 041526c6ef669743afc6c4b757b95011f1475d1a (diff) | |
| download | go-9fe9853ae5641eda4cfa58015bd0bcedb99c12cb.tar.gz go-9fe9853ae5641eda4cfa58015bd0bcedb99c12cb.zip | |
cmd/compile: fix nilcheck for AIX
This commit adapts compile tool to create correct nilchecks for AIX.
AIX allows to load a nil pointer. Therefore, the default nilcheck
which issues a load must be replaced by a CMP instruction followed by a
store at 0x0 if the value is nil. The store will trigger a SIGSEGV as on
others OS.
The nilcheck algorithm must be adapted to do not remove nilcheck if it's
only a read. Stores are detected with v.Type.IsMemory().
Tests related to nilptr must be adapted to the previous changements.
nilptr.go cannot be used as it's because the AIX address space starts at
1<<32.
Change-Id: I9f5aaf0b7e185d736a9b119c0ed2fe4e5bd1e7af
Reviewed-on: https://go-review.googlesource.com/c/144538
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'test/nilptr.go')
| -rw-r--r-- | test/nilptr.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/test/nilptr.go b/test/nilptr.go index 8d674a7098..90f57c54b6 100644 --- a/test/nilptr.go +++ b/test/nilptr.go @@ -7,6 +7,9 @@ // Test that the implementation catches nil ptr indirection // in a large address space. +// +build !aix +// Address space starts at 1<<32 on AIX, so dummy is too far. + package main import "unsafe" |