diff options
| author | Joel Sing <joel@sing.id.au> | 2020-01-29 20:06:54 +1100 |
|---|---|---|
| committer | Joel Sing <joel@sing.id.au> | 2020-01-29 16:34:44 +0000 |
| commit | 2e4f490b31272a2df73d4ba23aad7f5a8ca49a2f (patch) | |
| tree | d61b963c59a8b43fc8b24df5216cd054e0a082a6 /test/live.go | |
| parent | 1319bb959c17b8e6c7b44b26c61e8f02850d9c46 (diff) | |
| download | go-2e4f490b31272a2df73d4ba23aad7f5a8ca49a2f.tar.gz go-2e4f490b31272a2df73d4ba23aad7f5a8ca49a2f.zip | |
cmd/compile,cmd/link: fix and re-enable open-coded defers on riscv64
The R_CALLRISCV relocation marker is on the JALR instruction, however the actual
relocation is currently two instructions previous for the AUIPC+ADDI sequence.
Adjust the platform dependent offset accordingly and re-enable open-coded defers.
Fixes #36786.
Change-Id: I71597c193c447930fbe94ce44b7355e89ae877bb
Reviewed-on: https://go-review.googlesource.com/c/go/+/216797
Run-TryBot: Joel Sing <joel@sing.id.au>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/live.go')
| -rw-r--r-- | test/live.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/test/live.go b/test/live.go index 02e0fd51e5..3df7ab01af 100644 --- a/test/live.go +++ b/test/live.go @@ -1,13 +1,9 @@ // errorcheckwithauto -0 -l -live -wb=0 -d=ssa/insert_resched_checks/off -// +build !ppc64,!ppc64le,!riscv64 +// +build !ppc64,!ppc64le // ppc64 needs a better tighten pass to make f18 pass // rescheduling checks need to be turned off because there are some live variables across the inserted check call -// TODO(jsing): these tests assume that open-coded defers are enabled, -// which is not currently the case on riscv64. Re-enable this test once -// open-coded defers are available - golang.org/issues/36786. - // Copyright 2014 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. |