diff options
author | Cherry Mui <cherryyz@google.com> | 2022-02-14 12:43:27 -0500 |
---|---|---|
committer | Dmitri Shuralyov <dmitshur@golang.org> | 2022-02-18 00:51:15 +0000 |
commit | a222963bc4c6f370a6d3bbf3954447433317b689 (patch) | |
tree | 9deb0a98d4d79bc07fa733f07463a6a11d40df95 /test/fixedbugs/issue51101.go | |
parent | 8a24f67ca73fc275646d768c66566af064f7ae09 (diff) | |
download | go-a222963bc4c6f370a6d3bbf3954447433317b689.tar.gz go-a222963bc4c6f370a6d3bbf3954447433317b689.zip |
[release-branch.go1.16] cmd/compile: correct type of pointer difference on RISCV64
Pointer comparison is lowered to the following on RISCV64
(EqPtr x y) => (SEQZ (SUB <x.Type> x y))
The difference of two pointers (the SUB) should not be pointer
type. Otherwise it can cause the GC to find a bad pointer.
Updates #51101.
Fixes #51198.
Change-Id: I7e73c2155c36ff403c032981a9aa9cccbfdf0f64
Reviewed-on: https://go-review.googlesource.com/c/go/+/385655
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1ed30ca537a05b887f8479027b6363a03f957610)
Reviewed-on: https://go-review.googlesource.com/c/go/+/386475
Diffstat (limited to 'test/fixedbugs/issue51101.go')
-rw-r--r-- | test/fixedbugs/issue51101.go | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/test/fixedbugs/issue51101.go b/test/fixedbugs/issue51101.go new file mode 100644 index 0000000000..a390e50da4 --- /dev/null +++ b/test/fixedbugs/issue51101.go @@ -0,0 +1,36 @@ +// run + +// Copyright 2022 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Issue 51101: on RISCV64, difference of two pointers +// was marked as pointer and crashes GC. + +package main + +var a, b int + +func main() { + F(&b, &a) +} + +//go:noinline +func F(a, b *int) bool { + x := a == b + G(x) + y := a != b + return y +} + +//go:noinline +func G(bool) { + grow([1000]int{20}) +} + +func grow(x [1000]int) { + if x[0] != 0 { + x[0]-- + grow(x) + } +} |