diff options
author | Matthew Dempsky <mdempsky@google.com> | 2019-04-16 16:32:26 -0700 |
---|---|---|
committer | Matthew Dempsky <mdempsky@google.com> | 2019-04-17 16:36:30 +0000 |
commit | 52d9ce89ef71d95a4ce5f1a92155bb0c0b811957 (patch) | |
tree | 4692a7760f3d15add410155b6c361eb0d876f127 /test/escape_runtime_atomic.go | |
parent | 755b50952c9571202322bf63a42254ea8ea5655c (diff) | |
download | go-52d9ce89ef71d95a4ce5f1a92155bb0c0b811957.tar.gz go-52d9ce89ef71d95a4ce5f1a92155bb0c0b811957.zip |
test: add escape regress tests for runtime and sync atomics
There weren't any tests to make sure these work correctly, and this
led to escape analysis regressions in both linux/s390x and js/wasm.
The underlying issue that cmd/compile is only getting some of these
correct because escape analysis doesn't understand //go:linkname is
still present, but at least this addresses the fragility aspect.
Updates #15283.
Change-Id: I546aee1899d098b2e3de45e9b33c3ca22de485f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/172420
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'test/escape_runtime_atomic.go')
-rw-r--r-- | test/escape_runtime_atomic.go | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/test/escape_runtime_atomic.go b/test/escape_runtime_atomic.go new file mode 100644 index 0000000000..6dfd4aa211 --- /dev/null +++ b/test/escape_runtime_atomic.go @@ -0,0 +1,33 @@ +// errorcheck -0 -m -l + +// Copyright 2019 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Test escape analysis for runtime/internal/atomic. + +package escape + +import ( + "runtime/internal/atomic" + "unsafe" +) + +// BAD: should be "leaking param content". +func Loadp(addr unsafe.Pointer) unsafe.Pointer { // ERROR "leaking param: addr" + return atomic.Loadp(addr) +} + +var ptr unsafe.Pointer + +func Storep() { + var x int // ERROR "moved to heap: x" + atomic.StorepNoWB(unsafe.Pointer(&ptr), unsafe.Pointer(&x)) +} + +func Casp1() { + // BAD: x doesn't need to be heap allocated + var x int // ERROR "moved to heap: x" + var y int // ERROR "moved to heap: y" + atomic.Casp1(&ptr, unsafe.Pointer(&x), unsafe.Pointer(&y)) +} |