diff options
| author | Cherry Mui <cherryyz@google.com> | 2022-03-16 13:07:57 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2022-04-04 18:02:38 +0000 |
| commit | eb75219438e3c3d8947373c1f27c3ac4abf7ee8b (patch) | |
| tree | 46ca701a6dbba62af4f76191f5017ed5b30b145d /src | |
| parent | 4e69fddc640c727865490706633833870408e6ff (diff) | |
| download | go-eb75219438e3c3d8947373c1f27c3ac4abf7ee8b.tar.gz go-eb75219438e3c3d8947373c1f27c3ac4abf7ee8b.zip | |
[release-branch.go1.17] cmd/link: mark unexported methods for plugins
When plugin is used, we already mark all exported methods
reachable. However, when the plugin and the host program share
a common package, an unexported method could also be reachable
from both the plugin and the host via interfaces. We need to mark
them as well.
Fixes #51736.
Updates #51621.
Change-Id: I1a70d3f96b66b803f2d0ab14d00ed0df276ea500
Reviewed-on: https://go-review.googlesource.com/c/go/+/393365
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 91631bc7e0131367eb051b581cf34573399ac592)
Reviewed-on: https://go-review.googlesource.com/c/go/+/397484
Diffstat (limited to 'src')
| -rw-r--r-- | src/cmd/link/internal/ld/deadcode.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/link/internal/ld/deadcode.go b/src/cmd/link/internal/ld/deadcode.go index e4fa75f8e1..21a9703791 100644 --- a/src/cmd/link/internal/ld/deadcode.go +++ b/src/cmd/link/internal/ld/deadcode.go @@ -350,7 +350,7 @@ func deadcode(ctxt *Link) { // in the last pass. rem := d.markableMethods[:0] for _, m := range d.markableMethods { - if (d.reflectSeen && m.isExported()) || d.ifaceMethod[m.m] { + if (d.reflectSeen && (m.isExported() || d.dynlink)) || d.ifaceMethod[m.m] { d.markMethod(m) } else { rem = append(rem, m) |