diff options
| author | Russ Cox <rsc@golang.org> | 2020-10-29 14:46:29 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2020-12-09 19:12:27 +0000 |
| commit | f1980efb92c011eab71aa61b68ccf58d845d1de7 (patch) | |
| tree | 8bfed500207b38cba5fc254c2531a9760d6a0154 /src/testing | |
| parent | 4f1b0a44cb46f3df28f5ef82e5769ebeac1bc493 (diff) | |
| download | go-f1980efb92c011eab71aa61b68ccf58d845d1de7.tar.gz go-f1980efb92c011eab71aa61b68ccf58d845d1de7.zip | |
all: update to use os.ReadDir where appropriate
os.ReadDir is a replacement for ioutil.ReadDir that returns
a slice of fs.DirEntry instead of fs.FileInfo, meaning it is the
more efficient form.
This CL updates call sites throughout the Go source tree
wherever possible. As usual, code built using the Go 1.4
bootstrap toolchain is not included. There is also a use in
go/build that appears in the public API and can't be changed,
at least not without additional changes.
Fixes #42026.
Change-Id: Icfc9dd52c6045020f6830e22c72128499462d561
Reviewed-on: https://go-review.googlesource.com/c/go/+/266366
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/testing')
| -rw-r--r-- | src/testing/testing_test.go | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/testing/testing_test.go b/src/testing/testing_test.go index d665a334e4..0f096980ca 100644 --- a/src/testing/testing_test.go +++ b/src/testing/testing_test.go @@ -5,7 +5,6 @@ package testing_test import ( - "io/ioutil" "os" "path/filepath" "testing" @@ -102,11 +101,11 @@ func testTempDir(t *testing.T) { if !fi.IsDir() { t.Errorf("dir %q is not a dir", dir) } - fis, err := ioutil.ReadDir(dir) + files, err := os.ReadDir(dir) if err != nil { t.Fatal(err) } - if len(fis) > 0 { - t.Errorf("unexpected %d files in TempDir: %v", len(fis), fis) + if len(files) > 0 { + t.Errorf("unexpected %d files in TempDir: %v", len(files), files) } } |