diff options
author | Ian Lance Taylor <iant@golang.org> | 2020-01-26 08:12:58 -0800 |
---|---|---|
committer | Ian Lance Taylor <iant@golang.org> | 2020-01-26 20:38:34 +0000 |
commit | c333d07ebe9268efc3cf4bd68319d65818c75966 (patch) | |
tree | 5b1146243035249d8e86bbdbd31afcaebd27cdcd /src/strconv | |
parent | 73d213708e3186b48d5147b8eb939fdfd51f1f8d (diff) | |
download | go-c333d07ebe9268efc3cf4bd68319d65818c75966.tar.gz go-c333d07ebe9268efc3cf4bd68319d65818c75966.zip |
strconv: stop describing Unicode graphic characters as non-ASCII
Fixes #36778
Change-Id: I3c4ce100fc219bda0ff1d7a086c2309ed695691d
Reviewed-on: https://go-review.googlesource.com/c/go/+/216478
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/strconv')
-rw-r--r-- | src/strconv/quote.go | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/strconv/quote.go b/src/strconv/quote.go index b50496a0ff..bcbdbc514d 100644 --- a/src/strconv/quote.go +++ b/src/strconv/quote.go @@ -145,8 +145,9 @@ func AppendQuoteToASCII(dst []byte, s string) []byte { } // QuoteToGraphic returns a double-quoted Go string literal representing s. -// The returned string uses Go escape sequences (\t, \n, \xFF, \u0100) for -// non-ASCII characters and non-printable characters as defined by IsGraphic. +// The returned string leaves Unicode graphic characters, as defined by +// IsGraphic, unchanged and uses Go escape sequences (\t, \n, \xFF, \u0100) +// for non-graphic characters. func QuoteToGraphic(s string) string { return quoteWith(s, '"', false, true) } @@ -185,9 +186,9 @@ func AppendQuoteRuneToASCII(dst []byte, r rune) []byte { } // QuoteRuneToGraphic returns a single-quoted Go character literal representing -// the rune. The returned string uses Go escape sequences (\t, \n, \xFF, -// \u0100) for non-ASCII characters and non-printable characters as defined -// by IsGraphic. +// the rune. If the rune is not a Unicode graphic character, +// as defined by IsGraphic, the returned string will use a Go escape sequence +// (\t, \n, \xFF, \u0100). func QuoteRuneToGraphic(r rune) string { return quoteRuneWith(r, '\'', false, true) } |