diff options
author | Joe Tsai <joetsai@digital-static.net> | 2017-10-19 17:31:31 -0700 |
---|---|---|
committer | Joe Tsai <joetsai@google.com> | 2017-11-02 18:17:22 +0000 |
commit | 08f19bbde1b01227fdc2fa2d326e4029bb74dd96 (patch) | |
tree | 47677662e92d111529f1f66d9731bf35c18b6bd0 /src/runtime/symtab.go | |
parent | 8585f9fdb176893992bc8096ff595148b14b1795 (diff) | |
download | go-08f19bbde1b01227fdc2fa2d326e4029bb74dd96.tar.gz go-08f19bbde1b01227fdc2fa2d326e4029bb74dd96.zip |
go/printer: forbid empty line before first comment in block
To improve readability when exported fields are removed,
forbid the printer from emitting an empty line before the first comment
in a const, var, or type block.
Also, when printing the "Has filtered or unexported fields." message,
add an empty line before it to separate the message from the struct
or interfact contents.
Before the change:
<<<
type NamedArg struct {
// Name is the name of the parameter placeholder.
//
// If empty, the ordinal position in the argument list will be
// used.
//
// Name must omit any symbol prefix.
Name string
// Value is the value of the parameter.
// It may be assigned the same value types as the query
// arguments.
Value interface{}
// contains filtered or unexported fields
}
>>>
After the change:
<<<
type NamedArg struct {
// Name is the name of the parameter placeholder.
//
// If empty, the ordinal position in the argument list will be
// used.
//
// Name must omit any symbol prefix.
Name string
// Value is the value of the parameter.
// It may be assigned the same value types as the query
// arguments.
Value interface{}
// contains filtered or unexported fields
}
>>>
Fixes #18264
Change-Id: I9fe17ca39cf92fcdfea55064bd2eaa784ce48c88
Reviewed-on: https://go-review.googlesource.com/71990
Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src/runtime/symtab.go')
-rw-r--r-- | src/runtime/symtab.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/runtime/symtab.go b/src/runtime/symtab.go index 2f426c7bf1..135fc1a7ad 100644 --- a/src/runtime/symtab.go +++ b/src/runtime/symtab.go @@ -642,7 +642,6 @@ func findfunc(pc uintptr) funcInfo { idx = uint32(len(datap.ftab) - 1) } if pc < datap.ftab[idx].entry { - // With multiple text sections, the idx might reference a function address that // is higher than the pc being searched, so search backward until the matching address is found. @@ -653,7 +652,6 @@ func findfunc(pc uintptr) funcInfo { throw("findfunc: bad findfunctab entry idx") } } else { - // linear search to find func with pc >= entry. for datap.ftab[idx+1].entry <= pc { idx++ |