diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2017-12-01 19:26:33 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-12-01 20:54:31 +0000 |
| commit | 7b57e21a075b876903c735b3988a5be86c01f078 (patch) | |
| tree | c126824b85ffcfd2ea87be2014a5b153d12fc254 /src/runtime/runtime-gdb_test.go | |
| parent | 2e5011d8029e29f37bae359f2b1d398212a961ee (diff) | |
| download | go-7b57e21a075b876903c735b3988a5be86c01f078.tar.gz go-7b57e21a075b876903c735b3988a5be86c01f078.zip | |
runtime: skip gdb tests earlier before blocking goroutines in a t.Parallel
Minor.
Makes reading failing runtime test stacktraces easier (by having fewer
goroutines to read) on machines where these gdb tests wouldn't have
ever run anyway.
Change-Id: I3fab0667e017f20ef3bf96a8cc4cfcc614d25b5c
Reviewed-on: https://go-review.googlesource.com/81575
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/runtime-gdb_test.go')
| -rw-r--r-- | src/runtime/runtime-gdb_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 1a70a5d7a1..5e0508631f 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -110,8 +110,8 @@ func testGdbPython(t *testing.T, cgo bool) { t.Skip("skipping because cgo is not enabled") } - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) checkGdbPython(t) @@ -266,8 +266,8 @@ func TestGdbBacktrace(t *testing.T) { testenv.SkipFlaky(t, 15603) } - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build") @@ -336,8 +336,8 @@ func main() { // TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info // See bug #17830. func TestGdbAutotmpTypes(t *testing.T) { - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build") @@ -401,8 +401,8 @@ func main() { ` func TestGdbConst(t *testing.T) { - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build") |