diff options
| author | David Crawshaw <crawshaw@golang.org> | 2016-02-20 22:54:15 -0500 |
|---|---|---|
| committer | David Crawshaw <crawshaw@golang.org> | 2016-03-08 23:23:13 +0000 |
| commit | a24b3ed7538dd2eb013005fb1e153468f486857a (patch) | |
| tree | 1984c416b16989a003a8adbdd2356fde7cffb7f2 /src/runtime/mfinal.go | |
| parent | 0321cabdfacc5472d2bc650de3e36ca10131b60a (diff) | |
| download | go-a24b3ed7538dd2eb013005fb1e153468f486857a.tar.gz go-a24b3ed7538dd2eb013005fb1e153468f486857a.zip | |
cmd/compile: remove rtype *uncommonType field
Instead of a pointer on every rtype, use a bit flag to indicate that
the contents of uncommonType directly follows the rtype value when it
is needed.
This requires a bit of juggling in the compiler's rtype encoder. The
backing arrays for fields in the rtype are presently encoded directly
after the slice header. This packing requires separating the encoding
of the uncommonType slice headers from their backing arrays.
Reduces binary size of godoc by ~180KB (1.5%).
No measurable change in all.bash time.
For #6853.
Change-Id: I60205948ceb5c0abba76fdf619652da9c465a597
Reviewed-on: https://go-review.googlesource.com/19790
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: David Crawshaw <crawshaw@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/mfinal.go')
| -rw-r--r-- | src/runtime/mfinal.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/mfinal.go b/src/runtime/mfinal.go index 95cd1ef2f5..6d5378200e 100644 --- a/src/runtime/mfinal.go +++ b/src/runtime/mfinal.go @@ -340,7 +340,7 @@ func SetFinalizer(obj interface{}, finalizer interface{}) { // ok - same type goto okarg case fint.kind&kindMask == kindPtr: - if (fint.x == nil || etyp.x == nil) && (*ptrtype)(unsafe.Pointer(fint)).elem == ot.elem { + if (fint.uncommon() == nil || etyp.uncommon() == nil) && (*ptrtype)(unsafe.Pointer(fint)).elem == ot.elem { // ok - not same type, but both pointers, // one or the other is unnamed, and same element type, so assignable. goto okarg |