diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2022-01-21 06:52:43 +0000 |
|---|---|---|
| committer | Dmitri Shuralyov <dmitshur@golang.org> | 2022-02-18 00:27:46 +0000 |
| commit | 8a24f67ca73fc275646d768c66566af064f7ae09 (patch) | |
| tree | 63c78b67745dac93e614e922c728a7286c50409b /src/runtime/export_test.go | |
| parent | 288ff40bf96f3860c85668c67fa01cdcdd91291f (diff) | |
| download | go-8a24f67ca73fc275646d768c66566af064f7ae09.tar.gz go-8a24f67ca73fc275646d768c66566af064f7ae09.zip | |
[release-branch.go1.16] runtime: simplify histogram buckets considerably
There was an off-by-one error in the time histogram buckets calculation
that caused the linear sub-buckets distances to be off by 2x.
The fix was trivial, but in writing tests I realized there was a much
simpler way to express the calculation for the histogram buckets, and
took the opportunity to do that here. The new bucket calculation also
fixes the bug.
For #50732.
Fixes #50733.
Change-Id: Idae89986de1c415ee4e148f778e0e101ca003ade
Reviewed-on: https://go-review.googlesource.com/c/go/+/380094
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 2e9dcb508647dc473a37ecfa244d2bc4a1843ab4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/384620
Diffstat (limited to 'src/runtime/export_test.go')
| -rw-r--r-- | src/runtime/export_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/runtime/export_test.go b/src/runtime/export_test.go index 59f72ae709..79f13d1b4b 100644 --- a/src/runtime/export_test.go +++ b/src/runtime/export_test.go @@ -1226,3 +1226,5 @@ func (th *TimeHistogram) Count(bucket, subBucket uint) (uint64, bool) { func (th *TimeHistogram) Record(duration int64) { (*timeHistogram)(th).record(duration) } + +var TimeHistogramMetricsBuckets = timeHistogramMetricsBuckets |