diff options
| author | Michael Matloob <matloob@golang.org> | 2016-10-28 15:28:18 -0400 |
|---|---|---|
| committer | Michael Matloob <matloob@golang.org> | 2016-10-28 19:52:13 +0000 |
| commit | b33030a72754cb55d6ec137e79facacb398c9be4 (patch) | |
| tree | f1046297cd1375b9341939cacd7029f20e66c03a /src/runtime/crash_cgo_test.go | |
| parent | 30651b3bbbfda86e8188dfd89cb326a4db085e25 (diff) | |
| download | go-b33030a72754cb55d6ec137e79facacb398c9be4.tar.gz go-b33030a72754cb55d6ec137e79facacb398c9be4.zip | |
runtime/pprof: write profiles in protobuf format.
Original Change by Daria Kolistratova <daria.kolistratova@intel.com>
Added functions with suffix proto and stuff from pprof tool to translate
to protobuf. Done as the profile proto is more extensible than the legacy
pprof format and is pprof's preferred profile format. Large part was taken
from https://github.com/google/pprof tool. Tested by hand and compared the
result with translated by pprof tool, profiles are identical.
Fixes #16093
Change-Id: I2751345b09a66ee2b6aa64be76cba4cd1c326aa6
Reviewed-on: https://go-review.googlesource.com/32257
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
Diffstat (limited to 'src/runtime/crash_cgo_test.go')
| -rw-r--r-- | src/runtime/crash_cgo_test.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 34d1f0594a..472afcb38b 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -271,10 +271,11 @@ func testCgoPprof(t *testing.T, buildArg, runArg string) { if err != nil { t.Fatal(err) } + fn := strings.TrimSpace(string(got)) defer os.Remove(fn) - cmd := testEnv(exec.Command(testenv.GoToolPath(t), "tool", "pprof", "-top", "-nodecount=1", exe, fn)) + cmd := testEnv(exec.Command(testenv.GoToolPath(t), "tool", "pprof", "-top", "-nodecount=1", "-symbolize=force", exe, fn)) found := false for i, e := range cmd.Env { |