diff options
| author | Keith Randall <khr@golang.org> | 2020-03-17 13:27:11 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2020-03-17 20:47:06 +0000 |
| commit | f4ddc00345af8ffc77fabe2f6f21d570288159c1 (patch) | |
| tree | 6971fab645578938444d742b85b9fb0d4ab2e41e /src/runtime/checkptr_test.go | |
| parent | 14d20dc4f38dda548f6991cc687bc71b250b1603 (diff) | |
| download | go-f4ddc00345af8ffc77fabe2f6f21d570288159c1.tar.gz go-f4ddc00345af8ffc77fabe2f6f21d570288159c1.zip | |
runtime: don't report a pointer alignment error for pointer-free base type
Fixes #37298
Change-Id: I8ba9c8b106e16cea7dd25473c7390b0f2ba9a1a5
Reviewed-on: https://go-review.googlesource.com/c/go/+/223781
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/checkptr_test.go')
| -rw-r--r-- | src/runtime/checkptr_test.go | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/src/runtime/checkptr_test.go b/src/runtime/checkptr_test.go index 1a7c253733..8ab8a4937c 100644 --- a/src/runtime/checkptr_test.go +++ b/src/runtime/checkptr_test.go @@ -24,7 +24,8 @@ func TestCheckPtr(t *testing.T) { cmd string want string }{ - {"CheckPtrAlignment", "fatal error: checkptr: misaligned pointer conversion\n"}, + {"CheckPtrAlignmentPtr", "fatal error: checkptr: misaligned pointer conversion\n"}, + {"CheckPtrAlignmentNoPtr", ""}, {"CheckPtrArithmetic", "fatal error: checkptr: pointer arithmetic result points to invalid allocation\n"}, {"CheckPtrSize", "fatal error: checkptr: converted pointer straddles multiple allocations\n"}, {"CheckPtrSmall", "fatal error: checkptr: pointer arithmetic computed bad pointer value\n"}, @@ -38,6 +39,12 @@ func TestCheckPtr(t *testing.T) { if err != nil { t.Log(err) } + if tc.want == "" { + if len(got) > 0 { + t.Errorf("output:\n%s\nwant no output", got) + } + return + } if !strings.HasPrefix(string(got), tc.want) { t.Errorf("output:\n%s\n\nwant output starting with: %s", got, tc.want) } |