all: treat all files as binary, but check in .bat with CRLF

This is a followup to CL 96495.

It should be simpler and more robust to achieve .bat files having
CRLF line endings by treating it as a binary file, like all other
files, and checking it in with the desired CRLF line endings.

A test is used to check the entire Go tree, short of directories
starting with "." and named "testdata", for any .bat files that
have anything other than strict CRLF line endings. This will help
catch any accidental modifications to existing .bat files or check
ins of new .bat files.

Importantly, this is compatible with how Gerrit serves .tar.gz files,
making it so that CRLF line endings are preserved.

The Go project is supported on many different environments, some of
which may have limited git implementations available, or none at all.
Relying on fewer git features and special rules makes it easier to
have confidence in the exact content of all files. Additionally, Go
development started in Subversion, moved to Perforce, then Mercurial,
and now uses Git.¹ Reducing its reliance on git-specific features will
help if there will be another transition in the project's future.

There are only 5 .bat files in the entire Go source tree, so a new one
being added is a rare event, and we prefer to do things in Go instead.
We still have the option of improving the experience for developers by
adding a pre-commit converter for .bat files to the git-codereview tool.

¹ https://groups.google.com/d/msg/golang-dev/sckirqOWepg/YmyT7dWJiocJ

Fixes #39391.
For #37791.

Change-Id: I6e202216322872f0307ac96f1b8d3f57cb901e6b
Reviewed-on: https://go-review.googlesource.com/c/go/+/236437
Reviewed-by: Bryan C. Mills <bcmills@google.com>

1 files changed, 59 insertions, 59 deletions

diff --git a/src/run.bat b/src/run.bat
index 69c181854b..90602b68cb 100644
--- a/src/run.bat
+++ b/src/run.bat
@@ -1,59 +1,59 @@
-:: Copyright 2012 The Go Authors. All rights reserved.
-:: Use of this source code is governed by a BSD-style
-:: license that can be found in the LICENSE file.
-
-@echo off
-
-if exist ..\bin\go.exe goto ok
-echo Must run run.bat from Go src directory after installing cmd/go.
-goto fail
-:ok
-
-:: Keep environment variables within this script
-:: unless invoked with --no-local.
-if x%1==x--no-local goto nolocal
-if x%2==x--no-local goto nolocal
-setlocal
-:nolocal
-
-set GOBUILDFAIL=0
-
-:: we disallow local import for non-local packages, if %GOROOT% happens
-:: to be under %GOPATH%, then some tests below will fail
-set GOPATH=
-:: Issue 14340: ignore GOBIN during all.bat.
-set GOBIN=
-set GOFLAGS=
-set GO111MODULE=
-
-rem TODO avoid rebuild if possible
-
-if x%1==x--no-rebuild goto norebuild
-echo ##### Building packages and commands.
-..\bin\go install -a -v std cmd
-if errorlevel 1 goto fail
-echo.
-:norebuild
-
-:: we must unset GOROOT_FINAL before tests, because runtime/debug requires
-:: correct access to source code, so if we have GOROOT_FINAL in effect,
-:: at least runtime/debug test will fail.
-set GOROOT_FINAL=
-
-:: get CGO_ENABLED
-..\bin\go env > env.bat
-if errorlevel 1 goto fail
-call env.bat
-del env.bat
-echo.
-
-..\bin\go tool dist test
-if errorlevel 1 goto fail
-echo.
-
-goto end
-
-:fail
-set GOBUILDFAIL=1
-
-:end
+:: Copyright 2012 The Go Authors. All rights reserved.

+:: Use of this source code is governed by a BSD-style

+:: license that can be found in the LICENSE file.

+

+@echo off

+

+if exist ..\bin\go.exe goto ok

+echo Must run run.bat from Go src directory after installing cmd/go.

+goto fail

+:ok

+

+:: Keep environment variables within this script

+:: unless invoked with --no-local.

+if x%1==x--no-local goto nolocal

+if x%2==x--no-local goto nolocal

+setlocal

+:nolocal

+

+set GOBUILDFAIL=0

+

+:: we disallow local import for non-local packages, if %GOROOT% happens

+:: to be under %GOPATH%, then some tests below will fail

+set GOPATH=

+:: Issue 14340: ignore GOBIN during all.bat.

+set GOBIN=

+set GOFLAGS=

+set GO111MODULE=

+

+rem TODO avoid rebuild if possible

+

+if x%1==x--no-rebuild goto norebuild

+echo ##### Building packages and commands.

+..\bin\go install -a -v std cmd

+if errorlevel 1 goto fail

+echo.

+:norebuild

+

+:: we must unset GOROOT_FINAL before tests, because runtime/debug requires

+:: correct access to source code, so if we have GOROOT_FINAL in effect,

+:: at least runtime/debug test will fail.

+set GOROOT_FINAL=

+

+:: get CGO_ENABLED

+..\bin\go env > env.bat

+if errorlevel 1 goto fail

+call env.bat

+del env.bat

+echo.

+

+..\bin\go tool dist test

+if errorlevel 1 goto fail

+echo.

+

+goto end

+

+:fail

+set GOBUILDFAIL=1

+

+:end