aboutsummaryrefslogtreecommitdiff
path: root/src/regexp
diff options
context:
space:
mode:
authorJoe Tsai <joetsai@digital-static.net>2017-10-19 17:31:31 -0700
committerJoe Tsai <joetsai@google.com>2017-11-02 18:17:22 +0000
commit08f19bbde1b01227fdc2fa2d326e4029bb74dd96 (patch)
tree47677662e92d111529f1f66d9731bf35c18b6bd0 /src/regexp
parent8585f9fdb176893992bc8096ff595148b14b1795 (diff)
downloadgo-08f19bbde1b01227fdc2fa2d326e4029bb74dd96.tar.gz
go-08f19bbde1b01227fdc2fa2d326e4029bb74dd96.zip
go/printer: forbid empty line before first comment in block
To improve readability when exported fields are removed, forbid the printer from emitting an empty line before the first comment in a const, var, or type block. Also, when printing the "Has filtered or unexported fields." message, add an empty line before it to separate the message from the struct or interfact contents. Before the change: <<< type NamedArg struct { // Name is the name of the parameter placeholder. // // If empty, the ordinal position in the argument list will be // used. // // Name must omit any symbol prefix. Name string // Value is the value of the parameter. // It may be assigned the same value types as the query // arguments. Value interface{} // contains filtered or unexported fields } >>> After the change: <<< type NamedArg struct { // Name is the name of the parameter placeholder. // // If empty, the ordinal position in the argument list will be // used. // // Name must omit any symbol prefix. Name string // Value is the value of the parameter. // It may be assigned the same value types as the query // arguments. Value interface{} // contains filtered or unexported fields } >>> Fixes #18264 Change-Id: I9fe17ca39cf92fcdfea55064bd2eaa784ce48c88 Reviewed-on: https://go-review.googlesource.com/71990 Run-TryBot: Joe Tsai <thebrokentoaster@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>
Diffstat (limited to 'src/regexp')
-rw-r--r--src/regexp/syntax/parse.go1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/regexp/syntax/parse.go b/src/regexp/syntax/parse.go
index 8c6d43a706..8b5b32a786 100644
--- a/src/regexp/syntax/parse.go
+++ b/src/regexp/syntax/parse.go
@@ -1626,7 +1626,6 @@ func (p *parser) parseClass(s string) (rest string, err error) {
// cleanClass sorts the ranges (pairs of elements of r),
// merges them, and eliminates duplicates.
func cleanClass(rp *[]rune) []rune {
-
// Sort by lo increasing, hi decreasing to break ties.
sort.Sort(ranges{rp})