diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2016-04-28 15:16:46 -0500 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-04-28 20:56:25 +0000 |
| commit | 1b591dfb1f071d978448966e979e40b1f265c1a5 (patch) | |
| tree | ee2c149e1f1a672bf149eb700c00df3fd823404a /src/os/exec/exec.go | |
| parent | 6c11e2710e96171e7c202940bf2b14aa859f5ca2 (diff) | |
| download | go-1b591dfb1f071d978448966e979e40b1f265c1a5.tar.gz go-1b591dfb1f071d978448966e979e40b1f265c1a5.zip | |
os/exec: fix variable shadow, don't leak goroutine
Goroutine leak checking is still too tedious, so untested.
See #6705 which is my fault for forgetting to mail out.
Change-Id: I899fb311c9d4229ff1dbd3f54fe307805e17efee
Reviewed-on: https://go-review.googlesource.com/22581
Reviewed-by: Ahmed W. <oneofone@gmail.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/os/exec/exec.go')
| -rw-r--r-- | src/os/exec/exec.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go index 76fcba90bf..5121b9b2cc 100644 --- a/src/os/exec/exec.go +++ b/src/os/exec/exec.go @@ -412,7 +412,7 @@ func (c *Cmd) WaitContext(ctx context.Context) error { var waitDone chan struct{} if ctx != nil { - waitDone := make(chan struct{}) + waitDone = make(chan struct{}) go func() { select { case <-ctx.Done(): |