diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2019-11-12 18:38:33 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2019-11-13 14:12:20 +0000 |
| commit | 54cf7760203c2b138d9ecf653cd3b2402444cf9b (patch) | |
| tree | 10f13e63e44cee2c13031996f2a99c02df3afed8 /src/net/http/transport_test.go | |
| parent | bf5f64107a5d750e53d0bfb046a3fd4dad3eb3e2 (diff) | |
| download | go-54cf7760203c2b138d9ecf653cd3b2402444cf9b.tar.gz go-54cf7760203c2b138d9ecf653cd3b2402444cf9b.zip | |
net/http: add some debugging to TestDontCacheBrokenHTTP2Conn
Not a fix, but will give us more info when it flakes again.
Updates #35113
Change-Id: I2f90c24530c1bea81dd9d8c7a59f4b0640dfa4c2
Reviewed-on: https://go-review.googlesource.com/c/go/+/206819
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/net/http/transport_test.go')
| -rw-r--r-- | src/net/http/transport_test.go | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/net/http/transport_test.go b/src/net/http/transport_test.go index 27be26cedc..62f1e36b38 100644 --- a/src/net/http/transport_test.go +++ b/src/net/http/transport_test.go @@ -5930,7 +5930,11 @@ func TestDontCacheBrokenHTTP2Conn(t *testing.T) { var brokenState brokenState + const numReqs = 5 + var numDials, gotConns uint32 // atomic + cst.tr.Dial = func(netw, addr string) (net.Conn, error) { + atomic.AddUint32(&numDials, 1) c, err := net.Dial(netw, addr) if err != nil { t.Errorf("unexpected Dial error: %v", err) @@ -5939,8 +5943,6 @@ func TestDontCacheBrokenHTTP2Conn(t *testing.T) { return &breakableConn{c, &brokenState}, err } - const numReqs = 5 - var gotConns uint32 // atomic for i := 1; i <= numReqs; i++ { brokenState.Lock() brokenState.broken = false @@ -5953,6 +5955,7 @@ func TestDontCacheBrokenHTTP2Conn(t *testing.T) { ctx := httptrace.WithClientTrace(context.Background(), &httptrace.ClientTrace{ GotConn: func(info httptrace.GotConnInfo) { + t.Logf("got conn: %v, reused=%v, wasIdle=%v, idleTime=%v", info.Conn.LocalAddr(), info.Reused, info.WasIdle, info.IdleTime) atomic.AddUint32(&gotConns, 1) }, TLSHandshakeDone: func(cfg tls.ConnectionState, err error) { @@ -5975,6 +5978,9 @@ func TestDontCacheBrokenHTTP2Conn(t *testing.T) { if got, want := atomic.LoadUint32(&gotConns), 1; int(got) != want { t.Errorf("GotConn calls = %v; want %v", got, want) } + if got, want := atomic.LoadUint32(&numDials), numReqs; int(got) != want { + t.Errorf("Dials = %v; want %v", got, want) + } } // Issue 34941 |