diff options
| author | Bryan C. Mills <bcmills@google.com> | 2021-12-06 22:09:12 -0500 |
|---|---|---|
| committer | Damien Neil <dneil@google.com> | 2021-12-07 17:52:27 +0000 |
| commit | e5ba7d3abf1e356f8cb7d760f95a389dd08c63ae (patch) | |
| tree | 5d5d0192ee08df971873e293256accb5ad93310c /src/net/http/serve_test.go | |
| parent | 4c943abb95578da4bfd70d365814a130da8d5aa2 (diff) | |
| download | go-e5ba7d3abf1e356f8cb7d760f95a389dd08c63ae.tar.gz go-e5ba7d3abf1e356f8cb7d760f95a389dd08c63ae.zip | |
net/http: remove arbitrary timeout in TestServerHijackGetsBackgroundByte_big
This test fails with "timeout" once per couple of months.
It may be that the arbitrary timeout is too short,
or it may be that the test is detecting a real bug
(perhaps a deadlock) and reporting it without sufficient
information to debug.
Either way, the arbitrary timeout is doing only harm:
either it is too short, or it is preventing us from getting
a useful goroutine dump when the test inevitably times out.
Fixes #35498 (hopefully).
Change-Id: Ic6bbb1ef8df2c111b9888ba9903f58633e7cb95d
Reviewed-on: https://go-review.googlesource.com/c/go/+/369854
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Diffstat (limited to 'src/net/http/serve_test.go')
| -rw-r--r-- | src/net/http/serve_test.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index 82c1a6716f..d46400ef75 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -5998,11 +5998,7 @@ func TestServerHijackGetsBackgroundByte_big(t *testing.T) { t.Fatal(err) } - select { - case <-done: - case <-time.After(2 * time.Second): - t.Error("timeout") - } + <-done } // Issue 18319: test that the Server validates the request method. |