diff options
author | Daniel Martà <mvdan@mvdan.cc> | 2018-10-03 21:01:14 +0100 |
---|---|---|
committer | Brad Fitzpatrick <bradfitz@golang.org> | 2018-10-03 20:13:35 +0000 |
commit | 112f28defcbd8f48de83f4502093ac97149b4da6 (patch) | |
tree | dc91268f72f65c2ba28e95501a85156a1834f4e1 /src/net/http/serve_test.go | |
parent | c91ce3cc7b13fce23edae94818e505f126036bdb (diff) | |
download | go-112f28defcbd8f48de83f4502093ac97149b4da6.tar.gz go-112f28defcbd8f48de83f4502093ac97149b4da6.zip |
io: export StringWriter
And start using it elsewhere in the standard library, removing the
copies in the process.
While at it, rewrite the io.WriteString godoc to be more clear, since it
can now make reference to the defined interface.
Fixes #27946.
Change-Id: Id5ba223c09c19e5fb49815bd3b1bd3254fc786f3
Reviewed-on: https://go-review.googlesource.com/c/139457
Run-TryBot: Daniel Martà <mvdan@mvdan.cc>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/net/http/serve_test.go')
-rw-r--r-- | src/net/http/serve_test.go | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index b12fcf4f9e..a282c4bc17 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -4028,21 +4028,18 @@ func TestRequestBodyCloseDoesntBlock(t *testing.T) { } } -// test that ResponseWriter implements io.stringWriter. +// test that ResponseWriter implements io.StringWriter. func TestResponseWriterWriteString(t *testing.T) { okc := make(chan bool, 1) ht := newHandlerTest(HandlerFunc(func(w ResponseWriter, r *Request) { - type stringWriter interface { - WriteString(s string) (n int, err error) - } - _, ok := w.(stringWriter) + _, ok := w.(io.StringWriter) okc <- ok })) ht.rawResponse("GET / HTTP/1.0") select { case ok := <-okc: if !ok { - t.Error("ResponseWriter did not implement io.stringWriter") + t.Error("ResponseWriter did not implement io.StringWriter") } default: t.Error("handler was never called") |