diff options
| author | Edan B <3d4nb3@gmail.com> | 2017-11-11 10:10:14 +0200 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-11-11 20:12:59 +0000 |
| commit | d96ebf8a6d26f6f5bcf46f9da04def4ad8ec08d9 (patch) | |
| tree | 029c014ca683a41abe57ea9839fc134c57d166e7 /src/net/http/httputil/reverseproxy.go | |
| parent | f01b928aad6a6f35b033a31f495e9a0c2d38770d (diff) | |
| download | go-d96ebf8a6d26f6f5bcf46f9da04def4ad8ec08d9.tar.gz go-d96ebf8a6d26f6f5bcf46f9da04def4ad8ec08d9.zip | |
net/http/httputil: make ReverseProxy close response body if ModifyResponse returns an error
Fixes #22658
Change-Id: I00e2b007d77b6f54798f7755d0b08e4fea824392
Reviewed-on: https://go-review.googlesource.com/77170
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/net/http/httputil/reverseproxy.go')
| -rw-r--r-- | src/net/http/httputil/reverseproxy.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/net/http/httputil/reverseproxy.go b/src/net/http/httputil/reverseproxy.go index a0f36d1221..b96bb21019 100644 --- a/src/net/http/httputil/reverseproxy.go +++ b/src/net/http/httputil/reverseproxy.go @@ -207,6 +207,7 @@ func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) { if err := p.ModifyResponse(res); err != nil { p.logf("http: proxy error: %v", err) rw.WriteHeader(http.StatusBadGateway) + res.Body.Close() return } } |