diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2017-03-23 03:56:23 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-03-23 05:02:34 +0000 |
| commit | c46226a6222eb8bc8b30b40e8ce09ebe00f5dade (patch) | |
| tree | 66450d4e2817176643873f554b8d4f6bda9cad47 /src/net/dial_test.go | |
| parent | b5e1ae46adb2d3552d5df78e6a410f479ef1efb2 (diff) | |
| download | go-c46226a6222eb8bc8b30b40e8ce09ebe00f5dade.tar.gz go-c46226a6222eb8bc8b30b40e8ce09ebe00f5dade.zip | |
net: mark TestDialerDualStack as flaky
It was already marked flaky for everything but the dashboard.
Remove that restriction. It's just flaky overall.
It's doing more harm than good.
Updates #13324
Change-Id: I36feff32a1b8681e77700f74b9c70cb4073268eb
Reviewed-on: https://go-review.googlesource.com/38459
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Diffstat (limited to 'src/net/dial_test.go')
| -rw-r--r-- | src/net/dial_test.go | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 9825bc92ab..e8547974b9 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -715,11 +715,8 @@ func TestDialerLocalAddr(t *testing.T) { } func TestDialerDualStack(t *testing.T) { - // This test is known to be flaky. Don't frighten regular - // users about it; only fail on the build dashboard. - if testenv.Builder() == "" { - testenv.SkipFlaky(t, 13324) - } + testenv.SkipFlaky(t, 13324) + if !supportsIPv4 || !supportsIPv6 { t.Skip("both IPv4 and IPv6 are required") } |