diff options
| author | Bryan C. Mills <bcmills@google.com> | 2019-10-22 10:22:28 -0400 |
|---|---|---|
| committer | Bryan C. Mills <bcmills@google.com> | 2019-10-22 15:15:06 +0000 |
| commit | 95544cc2c2667872a034887417f383ef14af1212 (patch) | |
| tree | d1dfd6b1adff05fbe9179a2998cc83726279254b /src/net/dial_test.go | |
| parent | 07ccdeb1927c77ede1d56ac6f1c1871183761ea4 (diff) | |
| download | go-95544cc2c2667872a034887417f383ef14af1212.tar.gz go-95544cc2c2667872a034887417f383ef14af1212.zip | |
net: ignore or skip known-flaky localhost Dial operations on macOS 10.12 builder
Fixes #22019
Fixes #32919
Change-Id: I60bf6c69b18c3e2d78b494e54adc958fe40134da
Reviewed-on: https://go-review.googlesource.com/c/go/+/202618
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/net/dial_test.go')
| -rw-r--r-- | src/net/dial_test.go | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 5a8d0e09ca..4569703d12 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -639,9 +639,11 @@ func TestDialerLocalAddr(t *testing.T) { } c, err := d.Dial(tt.network, addr) if err == nil && tt.error != nil || err != nil && tt.error == nil { - // On Darwin this occasionally times out. - // We don't know why. Issue #22019. - if runtime.GOOS == "darwin" && tt.error == nil && os.IsTimeout(err) { + // A suspected kernel bug in macOS 10.12 occasionally results in + // timeout errors when dialing address ::1. The errors have not + // been observed on newer versions of the OS, so we don't plan to work + // around them. See https://golang.org/issue/22019. + if tt.raddr == "::1" && os.Getenv("GO_BUILDER_NAME") == "darwin-amd64-10_12" && os.IsTimeout(err) { t.Logf("ignoring timeout error on Darwin; see https://golang.org/issue/22019") } else { t.Errorf("%s %v->%s: got %v; want %v", tt.network, tt.laddr, tt.raddr, err, tt.error) |