diff options
author | Cherry Mui <cherryyz@google.com> | 2022-05-18 11:58:53 -0400 |
---|---|---|
committer | Cherry Mui <cherryyz@google.com> | 2022-07-26 14:16:52 +0000 |
commit | d9242f7a8c29aa17201cd66d29cdd20916c2de60 (patch) | |
tree | d851257974dae2308cca8ff12f752f1786f121f7 /src/math/big/ratmarsh_test.go | |
parent | 489c1485780f6326fb5f446bd9d97dff2ff0abcf (diff) | |
download | go-d9242f7a8c29aa17201cd66d29cdd20916c2de60.tar.gz go-d9242f7a8c29aa17201cd66d29cdd20916c2de60.zip |
[release-branch.go1.17] cmd/compile: do not use special literal assignment if LHS is address-taken
A composite literal assignment
x = T{field: v}
may be compiled to
x = T{}
x.field = v
We already do not use this form is RHS uses LHS. If LHS is
address-taken, RHS may uses LHS implicitly, e.g.
v = &x.field
x = T{field: *v}
The lowering above would change the value of RHS (*v).
Updates #52953.
Fixes #52960.
Change-Id: I3f798e00598aaa550b8c17182c7472fef440d483
Reviewed-on: https://go-review.googlesource.com/c/go/+/407014
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 1c77137d4fdfbb3e7e8d9efaab3bab5ee736a19d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/419451
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Diffstat (limited to 'src/math/big/ratmarsh_test.go')
0 files changed, 0 insertions, 0 deletions