diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2021-07-09 11:15:23 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2021-07-10 00:13:05 +0000 |
| commit | 5059aed9dd33e35d3d0d88be945b2aed8265e1c3 (patch) | |
| tree | 06a9fa823043c375679d903f978e98b645396748 /src/internal | |
| parent | f2ed30c31edf67bd753a10891dfeb5aeb65c95dd (diff) | |
| download | go-5059aed9dd33e35d3d0d88be945b2aed8265e1c3.tar.gz go-5059aed9dd33e35d3d0d88be945b2aed8265e1c3.zip | |
[dev.typeparams] internal/buildcfg: allow regabiwrappers on all GOARCH
There's nothing GOARCH-specific about ABI wrappers, so allow enabling
them on all architectures.
For unified IR, I want to have a testing mode where we add dictionary
parameters even to non-generic functions, as a way to help stress test
that they're handled correctly. This requires callers to know to
supply the appropriate dictionary arguments when calling them. Calls
generated by the Go compiler know to do this, but calls written in
assembly won't.
Reusing the regabi wrappers is a convenient choke-point for inserting
dictionary arguments for assembly calls.
Change-Id: Ic2c06b7626730289c5405829b61653d1daec430b
Reviewed-on: https://go-review.googlesource.com/c/go/+/333453
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/internal')
| -rw-r--r-- | src/internal/buildcfg/exp.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/internal/buildcfg/exp.go b/src/internal/buildcfg/exp.go index 6e8bf30743..0245574ec1 100644 --- a/src/internal/buildcfg/exp.go +++ b/src/internal/buildcfg/exp.go @@ -111,7 +111,6 @@ func ParseGOEXPERIMENT(goos, goarch, goexp string) (flags, baseline goexperiment } // regabi is only supported on amd64 and arm64. if goarch != "amd64" && goarch != "arm64" { - flags.RegabiWrappers = false flags.RegabiReflect = false flags.RegabiArgs = false } |