diff options
| author | Cherry Mui <cherryyz@google.com> | 2021-08-02 12:18:19 -0400 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2021-08-11 16:59:43 +0000 |
| commit | eeb7899137cda1c2cd60dab65ff41f627436db5b (patch) | |
| tree | 62b709aaec0f5390b00b6c55899c4f4051a84869 /src/internal/buildcfg/exp.go | |
| parent | 0888a8cd2dc3ad66e30ccb30eae8fbed065ea0f7 (diff) | |
| download | go-eeb7899137cda1c2cd60dab65ff41f627436db5b.tar.gz go-eeb7899137cda1c2cd60dab65ff41f627436db5b.zip | |
[dev.typeparams] internal/buildcfg: always enable regabi on AMD64
In Go 1.17 we added register ABI on AMD64 on Linux/macOS/Windows
as a GOEXPERIMENT, on by default. In Go 1.18, we commit to always
enabling register ABI on AMD64.
Now "go build" for AMD64 always have goexperiment.regabi* tags
set. However, at bootstrapping cmd/dist does not set the tags
when building go_bootstrap. For this to work, unfortunately, we
need to hard-code AMD64 to use register ABI in runtime code.
Change-Id: I0b31e678e186b9cdeeb8502cd9e38ed0d7e72d4f
Reviewed-on: https://go-review.googlesource.com/c/go/+/341151
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/internal/buildcfg/exp.go')
| -rw-r--r-- | src/internal/buildcfg/exp.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/internal/buildcfg/exp.go b/src/internal/buildcfg/exp.go index 0245574ec1..384f2f96af 100644 --- a/src/internal/buildcfg/exp.go +++ b/src/internal/buildcfg/exp.go @@ -105,9 +105,11 @@ func ParseGOEXPERIMENT(goos, goarch, goexp string) (flags, baseline goexperiment } } - // regabiwrappers is always enabled on amd64. + // regabi is always enabled on amd64. if goarch == "amd64" { flags.RegabiWrappers = true + flags.RegabiReflect = true + flags.RegabiArgs = true } // regabi is only supported on amd64 and arm64. if goarch != "amd64" && goarch != "arm64" { |