diff options
| author | Dong-hee Na <donghee.na92@gmail.com> | 2019-05-15 02:40:12 +0900 |
|---|---|---|
| committer | Daniel Martí <mvdan@mvdan.cc> | 2019-08-27 17:41:33 +0000 |
| commit | b9bf2f5d2bb117f806aef84d99ad60adbcb0cc21 (patch) | |
| tree | 86e97bd9e9bc7c8dc7a44cadb8ce26d2ff239942 /src/html | |
| parent | 72e71b90f3e808900279433c581af272d5b9afa4 (diff) | |
| download | go-b9bf2f5d2bb117f806aef84d99ad60adbcb0cc21.tar.gz go-b9bf2f5d2bb117f806aef84d99ad60adbcb0cc21.zip | |
html/template: micro optimization for isJSType
There is an unnecessary lower operation in isJSType.
Simple logic fix can improve tiny performance.
name old time/op new time/op delta
isJSType-8 152ns ± 0% 58ns ± 7% -61.82% (p=0.001 n=6+8)
name old alloc/op new alloc/op delta
isJSType-8 32.0B ± 0% 0.0B -100.00% (p=0.000 n=8+8)
name old allocs/op new allocs/op delta
isJSType-8 1.00 ± 0% 0.00 -100.00% (p=0.000 n=8+8)
Change-Id: I281aadf1677d4377920c9649af206381189a27e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/177118
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Diffstat (limited to 'src/html')
| -rw-r--r-- | src/html/template/js.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/html/template/js.go b/src/html/template/js.go index 7025c1cfaa..0e91458d19 100644 --- a/src/html/template/js.go +++ b/src/html/template/js.go @@ -383,11 +383,11 @@ func isJSType(mimeType string) bool { // https://tools.ietf.org/html/rfc7231#section-3.1.1 // https://tools.ietf.org/html/rfc4329#section-3 // https://www.ietf.org/rfc/rfc4627.txt - mimeType = strings.ToLower(mimeType) // discard parameters if i := strings.Index(mimeType, ";"); i >= 0 { mimeType = mimeType[:i] } + mimeType = strings.ToLower(mimeType) mimeType = strings.TrimSpace(mimeType) switch mimeType { case |