diff options
| author | Russ Cox <rsc@golang.org> | 2020-09-18 12:30:10 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2020-10-12 16:30:45 +0000 |
| commit | 9e2acf94fe1baa8bdffb21c2d54e0186ac88b68b (patch) | |
| tree | 4d7198840f7fcfa48c24d590304b10ecfcad406b /src/hash | |
| parent | 9384d34c58099657bb1b133beaf3ff37ada9b017 (diff) | |
| download | go-9e2acf94fe1baa8bdffb21c2d54e0186ac88b68b.tar.gz go-9e2acf94fe1baa8bdffb21c2d54e0186ac88b68b.zip | |
hash/maphash: adjust package comment
Add note about using per-use seeds.
Delete "collision-resistant but" in:
> The hash functions are collision-resistant but not cryptographically secure.
"Collision-resistant" has a precise cryptographic meaning that is
incompatible with "not cryptographically secure".
All that is really meant by it here here is "it's a good hash function",
which should be established already.
Also delete:
> The hash value of a given byte sequence is consistent within a
> single process, but will be different in different processes.
This was added for its final clause in response to #37040,
but "The hash value of a given byte sequence" is by design not a
concept in this package. Only "... of a given seed and byte sequence".
And seeds cannot be shared between processes, so again by design
you can't even set up the appropriate first half of the sentence
to say the second half.
Change-Id: I2c02bee0e804ef3b120cb4752bf89e60f3f5ff5d
Reviewed-on: https://go-review.googlesource.com/c/go/+/255968
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/hash')
| -rw-r--r-- | src/hash/maphash/maphash.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/hash/maphash/maphash.go b/src/hash/maphash/maphash.go index 071dc04b54..ecc147d599 100644 --- a/src/hash/maphash/maphash.go +++ b/src/hash/maphash/maphash.go @@ -6,12 +6,11 @@ // These hash functions are intended to be used to implement hash tables or // other data structures that need to map arbitrary strings or byte // sequences to a uniform distribution on unsigned 64-bit integers. +// Each different instance of a hash table or data structure should use its own Seed. // -// The hash functions are collision-resistant but not cryptographically secure. +// The hash functions are not cryptographically secure. // (See crypto/sha256 and crypto/sha512 for cryptographic use.) // -// The hash value of a given byte sequence is consistent within a -// single process, but will be different in different processes. package maphash import "unsafe" |