diff options
| author | Russ Cox <rsc@golang.org> | 2021-01-08 17:02:41 -0500 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2021-01-19 20:07:52 +0000 |
| commit | 0575e35e506cb180c5743209684b57dd41b4365f (patch) | |
| tree | 45b0a984f3d71f59a6e8c935c2a845af3df81762 /src/go | |
| parent | ccb2e906882e45fe2d22c31049185208adbfb62e (diff) | |
| download | go-0575e35e506cb180c5743209684b57dd41b4365f.tar.gz go-0575e35e506cb180c5743209684b57dd41b4365f.zip | |
cmd/compile: require 'go 1.16' go.mod line for //go:embed
This will produce better errors when earlier versions of
Go compile code using //go:embed. (The import will cause
a compilation error but then the go command will add to
the output that the Go toolchain in use looks too old
and maybe that's the problem.)
This CL also adds a test for disallowing embed of a var inside a func.
It's a bit too difficult to rebase down into that CL.
The build system configuration check is delayed in order to
make it possible to use errorcheck for these tests.
Change-Id: I12ece4ff2d8d53380b63f54866e8f3497657d54c
Reviewed-on: https://go-review.googlesource.com/c/go/+/282718
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/go')
| -rw-r--r-- | src/go/types/stdlib_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/go/types/stdlib_test.go b/src/go/types/stdlib_test.go index 23f8f9a18d..5ca44936ea 100644 --- a/src/go/types/stdlib_test.go +++ b/src/go/types/stdlib_test.go @@ -155,6 +155,8 @@ func TestStdTest(t *testing.T) { testTestDir(t, filepath.Join(runtime.GOROOT(), "test"), "cmplxdivide.go", // also needs file cmplxdivide1.go - ignore "directive.go", // tests compiler rejection of bad directive placement - ignore + "embedfunc.go", // tests //go:embed + "embedvers.go", // tests //go:embed ) } |