diff options
author | Alan Donovan <adonovan@google.com> | 2016-04-07 10:07:10 -0400 |
---|---|---|
committer | Alan Donovan <adonovan@google.com> | 2016-04-07 14:21:18 +0000 |
commit | 95a895df0c64b0cd1283c4cf7794d491427d765c (patch) | |
tree | a8d7b2431e2f7ea5d3ffdf2ebcac731340495b5e /src/go/types/api_test.go | |
parent | 9cc9e95b288648d796d92f0b92cb713b35f20062 (diff) | |
download | go-95a895df0c64b0cd1283c4cf7794d491427d765c.tar.gz go-95a895df0c64b0cd1283c4cf7794d491427d765c.zip |
go/types: make Identical(nil, T) == Identical(T, nil)
Fixes #15173
Change-Id: I353756f7bc36db0d2b24d40c80771481b7b18f6b
Reviewed-on: https://go-review.googlesource.com/21585
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/go/types/api_test.go')
-rw-r--r-- | src/go/types/api_test.go | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/src/go/types/api_test.go b/src/go/types/api_test.go index c2feed3813..9573d80a17 100644 --- a/src/go/types/api_test.go +++ b/src/go/types/api_test.go @@ -1042,3 +1042,20 @@ func f() { } } } + +func TestIdentical_issue15173(t *testing.T) { + // Identical should allow nil arguments and be symmetric. + for _, test := range []struct { + x, y Type + want bool + }{ + {Typ[Int], Typ[Int], true}, + {Typ[Int], nil, false}, + {nil, Typ[Int], false}, + {nil, nil, true}, + } { + if got := Identical(test.x, test.y); got != test.want { + t.Errorf("Identical(%v, %v) = %t", test.x, test.y, got) + } + } +} |