diff options
| author | Ian Lance Taylor <iant@golang.org> | 2016-08-14 20:39:30 -0700 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2016-08-23 16:26:43 +0000 |
| commit | 5e66ac9ac61efb045f8ae28ff0fc019a4a98b473 (patch) | |
| tree | 30528b8012e6c687a19b93e97497de255696c9e3 /src/flag | |
| parent | eb29ac7a7cf97cd364c9d343377b104bc3e90927 (diff) | |
| download | go-5e66ac9ac61efb045f8ae28ff0fc019a4a98b473.tar.gz go-5e66ac9ac61efb045f8ae28ff0fc019a4a98b473.zip | |
flag: document that Value.String must work on the zero value
Otherwise flag.PrintDefaults will fail when it tries to determine
whether the default is the zero value.
Fixes #16694.
Change-Id: I253fbf11ffc0a9069fd48c2c3cf3074df53e3a03
Reviewed-on: https://go-review.googlesource.com/27003
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/flag')
| -rw-r--r-- | src/flag/flag.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/flag/flag.go b/src/flag/flag.go index fa0f05e968..6c9b292b26 100644 --- a/src/flag/flag.go +++ b/src/flag/flag.go @@ -238,6 +238,7 @@ func (d *durationValue) String() string { return (*time.Duration)(d).String() } // rather than using the next command-line argument. // // Set is called once, in command line order, for each flag present. +// String must work on the zero value of the dynamic type. type Value interface { String() string Set(string) error |