diff options
| author | Karel Pazdera <pazderak@gmail.com> | 2017-08-24 00:36:28 +0200 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-08-24 00:55:59 +0000 |
| commit | 6e9e9dfa46e032657af06aaea669e4d2264cb79e (patch) | |
| tree | 968364302d390e72a92a37b87cf99dcf10c85d18 /src/encoding/xml/read_test.go | |
| parent | 77b4beba2fd892a3f8e9da527fdad031f6ecc613 (diff) | |
| download | go-6e9e9dfa46e032657af06aaea669e4d2264cb79e.tar.gz go-6e9e9dfa46e032657af06aaea669e4d2264cb79e.zip | |
encoding/xml: improve package based on the suggestions from metalinter
Existing code in encoding/xml packages contains code which breaks
various linter rules (comments, constant and variable naming, variable
shadowing, etc).
Fixes #21578
Change-Id: Id4bd9a9be6d5728ce88fb6efe33030ef943c078c
Reviewed-on: https://go-review.googlesource.com/58210
Reviewed-by: Sam Whited <sam@samwhited.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Sam Whited <sam@samwhited.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/encoding/xml/read_test.go')
| -rw-r--r-- | src/encoding/xml/read_test.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/encoding/xml/read_test.go b/src/encoding/xml/read_test.go index a1eb516187..bd6260d6d4 100644 --- a/src/encoding/xml/read_test.go +++ b/src/encoding/xml/read_test.go @@ -83,7 +83,7 @@ not being used from outside intra_region_diff.py. type Feed struct { XMLName Name `xml:"http://www.w3.org/2005/Atom feed"` Title string `xml:"title"` - Id string `xml:"id"` + ID string `xml:"id"` Link []Link `xml:"link"` Updated time.Time `xml:"updated,attr"` Author Person `xml:"author"` @@ -92,7 +92,7 @@ type Feed struct { type Entry struct { Title string `xml:"title"` - Id string `xml:"id"` + ID string `xml:"id"` Link []Link `xml:"link"` Updated time.Time `xml:"updated"` Author Person `xml:"author"` @@ -123,7 +123,7 @@ var atomFeed = Feed{ {Rel: "alternate", Href: "http://codereview.appspot.com/"}, {Rel: "self", Href: "http://codereview.appspot.com/rss/mine/rsc"}, }, - Id: "http://codereview.appspot.com/", + ID: "http://codereview.appspot.com/", Updated: ParseTime("2009-10-04T01:35:58+00:00"), Author: Person{ Name: "rietveld<>", @@ -140,7 +140,7 @@ var atomFeed = Feed{ Name: "email-address-removed", InnerXML: "<name>email-address-removed</name>", }, - Id: "urn:md5:134d9179c41f806be79b3a5f7877d19a", + ID: "urn:md5:134d9179c41f806be79b3a5f7877d19a", Summary: Text{ Type: "html", Body: ` @@ -187,7 +187,7 @@ the top of feeds.py marked NOTE(rsc). Name: "email-address-removed", InnerXML: "<name>email-address-removed</name>", }, - Id: "urn:md5:0a2a4f19bb815101f0ba2904aed7c35a", + ID: "urn:md5:0a2a4f19bb815101f0ba2904aed7c35a", Summary: Text{ Type: "html", Body: ` |