diff options
author | Ian Lance Taylor <iant@golang.org> | 2016-03-01 14:52:18 -0800 |
---|---|---|
committer | Ian Lance Taylor <iant@golang.org> | 2016-03-02 00:04:53 +0000 |
commit | 8b4deb448e587802f67930b765c9598fc8cd36e5 (patch) | |
tree | 40bb8ba92ea4f7b556f4a00b59aca21c8babc912 /src/encoding/gob/decode.go | |
parent | 88e18032bd76656afcf246c1a252e04cf462b41e (diff) | |
download | go-8b4deb448e587802f67930b765c9598fc8cd36e5.tar.gz go-8b4deb448e587802f67930b765c9598fc8cd36e5.zip |
cmd/compile: fix OADDSTR buffer size calculation
The size calculation has been wrong since this code was first committed
in https://golang.org/cl/3120. The effect was that the compiler always
allocated a temporary buffer on the stack for a non-escaping string
concatenation. This turns out to make no practical difference, as the
compiler always allocates a buffer of the same size (32 bytes) and the
runtime only uses the temporary buffer if the concatenated strings
fit (check is in rawstringtmp in runtime/string.go).
The effect of this change is to avoid generating a temporary buffer on
the stack that will not be used.
Change-Id: Id632bfe3d6c113c9934c018a2dd4bcbf1784a63d
Reviewed-on: https://go-review.googlesource.com/20112
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/encoding/gob/decode.go')
0 files changed, 0 insertions, 0 deletions