diff options
| author | Joe Tsai <thebrokentoaster@gmail.com> | 2017-12-01 00:59:45 +0000 |
|---|---|---|
| committer | Joe Tsai <joetsai@google.com> | 2017-12-01 01:12:26 +0000 |
| commit | b53088a63436ac49d2344a733a50d529b5f7244e (patch) | |
| tree | 9aeacef6839fd1e6c8ad28be2b3cb45756f6a19f /src/encoding/base32 | |
| parent | 206568566473e9a91c05b8b0153d27ecbee466b7 (diff) | |
| download | go-b53088a63436ac49d2344a733a50d529b5f7244e.tar.gz go-b53088a63436ac49d2344a733a50d529b5f7244e.zip | |
Revert "go/printer: forbid empty line before first comment in block"
This reverts commit 08f19bbde1b01227fdc2fa2d326e4029bb74dd96.
Reason for revert:
The changed transformation takes effect on a larger set
of code snippets than expected.
For example, this:
func foo() {
// Comment
bar()
}
becomes:
func foo() {
// Comment
bar()
}
This is an unintended consequence.
Change-Id: Ifca88d6267dab8a8170791f7205124712bf8ace8
Reviewed-on: https://go-review.googlesource.com/81335
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Joe Tsai <joetsai@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/encoding/base32')
| -rw-r--r-- | src/encoding/base32/base32.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/encoding/base32/base32.go b/src/encoding/base32/base32.go index e0a6e04b1d..e72ba74983 100644 --- a/src/encoding/base32/base32.go +++ b/src/encoding/base32/base32.go @@ -290,6 +290,7 @@ func (enc *Encoding) decode(dst, src []byte) (n int, end bool, err error) { dlen := 8 for j := 0; j < 8; { + // We have reached the end and are missing padding if len(src) == 0 && enc.padChar != NoPadding { return n, false, CorruptInputError(olen - len(src) - j) |