aboutsummaryrefslogtreecommitdiff
path: root/src/crypto
diff options
context:
space:
mode:
authorCherry Zhang <cherryyz@google.com>2020-09-28 17:43:44 -0400
committerCherry Zhang <cherryyz@google.com>2020-09-29 14:36:12 +0000
commit0163bdae685c1b060f8108ac5af13ea6374555b1 (patch)
tree9bfe978cb05d12a871013e6b9257743da2b0f5d1 /src/crypto
parent815a5e29f434281c9ae3740ad43aadd4464ae15e (diff)
downloadgo-0163bdae685c1b060f8108ac5af13ea6374555b1.tar.gz
go-0163bdae685c1b060f8108ac5af13ea6374555b1.zip
crypto/tls: fix TestLinkerGC test
A test that checks if "tls.(*Conn)" appears in any symbol's name. tls.Conn is a type, so the string "tls.(*Conn)" can only appear in the name of a method of Conn. But the test code doesn't use any of the methods. Not sure why this needs to be live. In particular, the linker is now able to prune all methods of Conn. Remove this requirement. In fact, just drop the only_conn test case, as simply allocating a type doesn't necessarily bring anything live. Change-Id: I754291b75d38e1465b5291b4dea20806615d21b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/257973 Trust: Cherry Zhang <cherryyz@google.com> Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Cherry Zhang <cherryyz@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Jeremy Faller <jeremy@golang.org>
Diffstat (limited to 'src/crypto')
-rw-r--r--src/crypto/tls/link_test.go13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/crypto/tls/link_test.go b/src/crypto/tls/link_test.go
index c1fb57e70e..8224216b5c 100644
--- a/src/crypto/tls/link_test.go
+++ b/src/crypto/tls/link_test.go
@@ -42,19 +42,6 @@ func main() {}
},
},
{
- name: "only_conn",
- program: `package main
-import "crypto/tls"
-var c = new(tls.Conn)
-func main() {}
-`,
- want: []string{"tls.(*Conn)"},
- bad: []string{
- "type.crypto/tls.clientHandshakeState",
- "type.crypto/tls.serverHandshakeState",
- },
- },
- {
name: "client_and_server",
program: `package main
import "crypto/tls"