diff options
| author | Tyler Bui-Palsulich <tpalsulich@google.com> | 2017-09-13 08:09:21 -0700 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-09-13 17:22:00 +0000 |
| commit | a696277243fdb8049de8e1b10ce6144a69b12c61 (patch) | |
| tree | ba66e25632efc6e3cae62dec464ada0261d0531a /src/container | |
| parent | de2231888821add783305e7674bbb43d4d8453dc (diff) | |
| download | go-a696277243fdb8049de8e1b10ce6144a69b12c61.tar.gz go-a696277243fdb8049de8e1b10ce6144a69b12c61.zip | |
container/heap: call t.Helper() in verify()
I modified verify() to fail every time to test the change. Before adding
t.Helper() (line 37 is in verify()):
/.../go/src/container/heap/heap_test.go:37: forced failure
FAIL
Afer adding t.Helper() (line 67 is where verify() is called):
/.../go/src/container/heap/heap_test.go:67: forced failure
FAIL
Fixes #21863
Change-Id: I46f0c8ec413cc664358c568fc53e48bb4a1d03d0
Reviewed-on: https://go-review.googlesource.com/63570
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/container')
| -rw-r--r-- | src/container/heap/heap_test.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/container/heap/heap_test.go b/src/container/heap/heap_test.go index d41110422e..f19f9cfa74 100644 --- a/src/container/heap/heap_test.go +++ b/src/container/heap/heap_test.go @@ -33,6 +33,7 @@ func (h *myHeap) Push(v interface{}) { } func (h myHeap) verify(t *testing.T, i int) { + t.Helper() n := h.Len() j1 := 2*i + 1 j2 := 2*i + 2 |