diff options
| author | Russ Cox <rsc@golang.org> | 2019-05-08 18:46:04 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2019-05-09 16:56:31 +0000 |
| commit | ffd7eba20a0b21e2af038ed4bedfe4a052aa22b7 (patch) | |
| tree | d6994453cf9885497230ad9e10cddf759ec0dc16 /src/cmd/vet | |
| parent | ff70494b75fab24f43b79f069afcdc196e11ec32 (diff) | |
| download | go-ffd7eba20a0b21e2af038ed4bedfe4a052aa22b7.tar.gz go-ffd7eba20a0b21e2af038ed4bedfe4a052aa22b7.zip | |
cmd/internal/bio: rename Reader.Seek to MustSeek
Renaming the method makes clear, both to readers and to vet,
that this method is not the implementation of io.Seeker:
it cannot fail.
Working toward making the tree vet-safe instead of having
so many exceptions in cmd/vet/all/whitelist.
For #31916.
Change-Id: I3e6ad7264cb0121b4b76935450cccb71d533e96b
Reviewed-on: https://go-review.googlesource.com/c/go/+/176108
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Diffstat (limited to 'src/cmd/vet')
| -rw-r--r-- | src/cmd/vet/all/whitelist/all.txt | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/cmd/vet/all/whitelist/all.txt b/src/cmd/vet/all/whitelist/all.txt index e12a96e0c5..cecd52b412 100644 --- a/src/cmd/vet/all/whitelist/all.txt +++ b/src/cmd/vet/all/whitelist/all.txt @@ -23,8 +23,6 @@ cmd/compile/internal/gc/testdata/short_test.go: unreachable code // These cases are basically ok. // Errors are handled reasonably and there's no clear need for interface satisfaction. // Except for the runtime/pprof case, the API is not exported. -cmd/internal/bio/buf.go: method Seek(offset int64, whence int) int64 should have signature Seek(int64, int) (int64, error) -cmd/internal/bio/buf.go: method Seek(offset int64, whence int) int64 should have signature Seek(int64, int) (int64, error) fmt/print.go: method WriteByte(c byte) should have signature WriteByte(byte) error // Also non-standard, but this method is on an unexported type, so it's |