diff options
| author | Cherry Zhang <cherryyz@google.com> | 2020-12-23 17:33:18 -0500 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2021-01-11 18:19:08 +0000 |
| commit | c3b4c7093ac46431b6e15cf1979bd9a251a400da (patch) | |
| tree | d92aca867ba6a1b710d92ca1ac89774397fad738 /src/cmd/objdump | |
| parent | 59bfc18e3441d9cd0b1b2f302935403bbf52ac8b (diff) | |
| download | go-c3b4c7093ac46431b6e15cf1979bd9a251a400da.tar.gz go-c3b4c7093ac46431b6e15cf1979bd9a251a400da.zip | |
cmd/internal/objfile: don't require runtime.symtab symbol for XCOFF
For some reason (that I didn't look into), externally linked
AIX binaries don't have runtime.symtab symbol. Since recent Go
releases (Go 1.3 maybe?), that symbol is empty and not necessary
anyway. Don't require it.
Fixes #40972.
Change-Id: I73a1f0142195ea6debdba8a4f6e12cadc3980dc5
Reviewed-on: https://go-review.googlesource.com/c/go/+/279995
Trust: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/objdump')
| -rw-r--r-- | src/cmd/objdump/objdump_test.go | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go index edaca774f7..1748e13a53 100644 --- a/src/cmd/objdump/objdump_test.go +++ b/src/cmd/objdump/objdump_test.go @@ -237,9 +237,6 @@ func testGoAndCgoDisasm(t *testing.T, printCode bool, printGnuAsm bool) { t.Parallel() testDisasm(t, "fmthello.go", printCode, printGnuAsm) if build.Default.CgoEnabled { - if runtime.GOOS == "aix" { - return // issue 40972 - } testDisasm(t, "fmthellocgo.go", printCode, printGnuAsm) } } @@ -261,8 +258,6 @@ func TestDisasmExtld(t *testing.T) { switch runtime.GOOS { case "plan9", "windows": t.Skipf("skipping on %s", runtime.GOOS) - case "aix": - t.Skipf("skipping on AIX, see issue 40972") } t.Parallel() testDisasm(t, "fmthello.go", false, false, "-ldflags=-linkmode=external") |