diff options
| author | Cherry Zhang <cherryyz@google.com> | 2020-06-30 19:09:38 +0000 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2020-06-30 20:14:48 +0000 |
| commit | 96e83664378918980bd8f60822c4bc39befcb668 (patch) | |
| tree | 7325478dbfef81e5e294140aa61bfee9286cdf1d /src/cmd/link/internal/ld/lib.go | |
| parent | 5779bb4e92911271583faa1365fd12be2c3894ee (diff) | |
| download | go-96e83664378918980bd8f60822c4bc39befcb668.tar.gz go-96e83664378918980bd8f60822c4bc39befcb668.zip | |
Revert "cmd/link: fix GC data reading from shared library"
This reverts CL 240462.
Reason for revert: test fails on PPC64LE.
Updates #39927.
Change-Id: I4f14fd0c36e604a80ae9f2f86d1e643e28945e93
Reviewed-on: https://go-review.googlesource.com/c/go/+/240616
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/link/internal/ld/lib.go')
| -rw-r--r-- | src/cmd/link/internal/ld/lib.go | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 802bfb2b24..61ccc28a1d 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -2124,9 +2124,7 @@ func ldshlibsyms(ctxt *Link, shlib string) { Errorf(nil, "cannot open shared library: %s", libpath) return } - // Keep the file open as decodetypeGcprog needs to read from it. - // TODO: fix. Maybe mmap the file. - //defer f.Close() + defer f.Close() hash, err := readnote(f, ELF_NOTE_GO_NAME, ELF_NOTE_GOABIHASH_TAG) if err != nil { |