diff options
| author | Cherry Zhang <cherryyz@google.com> | 2020-04-30 21:15:54 -0400 |
|---|---|---|
| committer | Cherry Zhang <cherryyz@google.com> | 2020-05-01 14:13:16 +0000 |
| commit | 1667b35740bd6974082cba6b48b4ea1881e29088 (patch) | |
| tree | 0ee148ac69a00db8d246d11779a31f7e47a04a83 /src/cmd/link/internal/ld/lib.go | |
| parent | 7aa6e0faf20d48956eaeead4a71992dd53306c19 (diff) | |
| download | go-1667b35740bd6974082cba6b48b4ea1881e29088.tar.gz go-1667b35740bd6974082cba6b48b4ea1881e29088.zip | |
[dev.link] cmd/link: directly use loader.ExtReloc in ELF relocation generation
Convert the part that uses relocations to use loader.ExtReloc
directly. It still uses sym.Symbols for now, but not sym.Relocs.
This reduces some memory usage: linking cmd/compile with external
linking,
name old allocs/op new allocs/op delta
Loadlibfull_GC 52.2MB ± 0% 13.9MB ± 0% -73.40% (p=0.008 n=5+5)
name old live-B new live-B delta
Loadlibfull_GC 75.5M ± 0% 61.9M ± 0% -18.02% (p=0.008 n=5+5)
Change-Id: I317ecbf516063c42b255b2caba310ea6281342d7
Reviewed-on: https://go-review.googlesource.com/c/go/+/231319
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Diffstat (limited to 'src/cmd/link/internal/ld/lib.go')
| -rw-r--r-- | src/cmd/link/internal/ld/lib.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index a328efd03b..3c60901124 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -270,6 +270,7 @@ type Arch struct { Asmb2 func(*Link) Elfreloc1 func(*Link, *sym.Reloc, int64) bool + Elfreloc2 func(*Link, *loader.Loader, loader.Sym, loader.ExtRelocView, int64) bool Elfsetupplt func(ctxt *Link, plt, gotplt *loader.SymbolBuilder, dynamic loader.Sym) Gentext func(*Link) Gentext2 func(*Link, *loader.Loader) @@ -2825,9 +2826,9 @@ func addToTextp(ctxt *Link) { ctxt.Textp = textp } -func (ctxt *Link) loadlibfull(symGroupType []sym.SymKind, needReloc bool) { +func (ctxt *Link) loadlibfull(symGroupType []sym.SymKind, needReloc, needExtReloc bool) { // Load full symbol contents, resolve indexed references. - ctxt.loader.LoadFull(ctxt.Arch, ctxt.Syms, needReloc) + ctxt.loader.LoadFull(ctxt.Arch, ctxt.Syms, needReloc, needExtReloc) // Convert ctxt.Moduledata2 to ctxt.Moduledata, etc if ctxt.Moduledata2 != 0 { |