diff options
| author | Alexander Menzhinsky <amenzhinsky@gmail.com> | 2017-03-03 15:57:19 +0300 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-03-17 17:49:29 +0000 |
| commit | be04da8f0c5cb57e2736cfac8c76971d7d8cfc6f (patch) | |
| tree | 71ea0e555a80a262f528d79df4fe97b122545087 /src/cmd/go/internal/test/testflag.go | |
| parent | b9f6b22a0100716db1f196a395f9ded8456337f8 (diff) | |
| download | go-be04da8f0c5cb57e2736cfac8c76971d7d8cfc6f.tar.gz go-be04da8f0c5cb57e2736cfac8c76971d7d8cfc6f.zip | |
cmd/go: fix race libraries rebuilding by `go test -i`
`go test -i -race` adds the "sync/atomic" package to every package dependency tree
that makes buildIDs different from packages installed with `go install -race`
and causes cache rebuilding.
Fixes #19133
Fixes #19151
Change-Id: I0536c6fa41b0d20fe361b5d35b3c0937b146d07d
Reviewed-on: https://go-review.googlesource.com/37598
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd/go/internal/test/testflag.go')
| -rw-r--r-- | src/cmd/go/internal/test/testflag.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/cmd/go/internal/test/testflag.go b/src/cmd/go/internal/test/testflag.go index 1c44af5a00..a89afb312e 100644 --- a/src/cmd/go/internal/test/testflag.go +++ b/src/cmd/go/internal/test/testflag.go @@ -174,7 +174,7 @@ func testFlags(args []string) (packageNames, passToTest []string) { case "covermode": switch value { case "set", "count", "atomic": - cfg.TestCoverMode = value + testCoverMode = value default: base.Fatalf("invalid flag argument for -covermode: %q", value) } @@ -191,11 +191,11 @@ func testFlags(args []string) (packageNames, passToTest []string) { } } - if cfg.TestCoverMode == "" { - cfg.TestCoverMode = "set" + if testCoverMode == "" { + testCoverMode = "set" if cfg.BuildRace { // Default coverage mode is atomic when -race is set. - cfg.TestCoverMode = "atomic" + testCoverMode = "atomic" } } |