diff options
| author | Daniel Martí <mvdan@mvdan.cc> | 2021-01-30 11:41:29 +0000 |
|---|---|---|
| committer | Daniel Martí <mvdan@mvdan.cc> | 2021-03-23 18:14:47 +0000 |
| commit | c59b17e5a2244f7a99c440a07a1c174344da0ad8 (patch) | |
| tree | 341f0db720566a1329f1e68259adc7c2d1daf076 /src/cmd/go/internal/test/test.go | |
| parent | 05250429ae0e43041c9976a8451426d3ad907e5a (diff) | |
| download | go-c59b17e5a2244f7a99c440a07a1c174344da0ad8.tar.gz go-c59b17e5a2244f7a99c440a07a1c174344da0ad8.zip | |
cmd/go: make -coverpkg=all skip test-only packages
Otherwise, the added test would fail in an unnecessary way:
go build example.com/cov/onlytest: no non-test Go files ...
The test script is mimicking other cover_pkgall_*.txt scripts, so it
similarly tests both GOPATH and module modes.
Fixes #27333.
Change-Id: Ie60be569b31d49b173a78556c0669a87ada6799e
Reviewed-on: https://go-review.googlesource.com/c/go/+/288292
Trust: Daniel Martí <mvdan@mvdan.cc>
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/test/test.go')
| -rw-r--r-- | src/cmd/go/internal/test/test.go | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/cmd/go/internal/test/test.go b/src/cmd/go/internal/test/test.go index ea9dfbe4e8..230ea2d318 100644 --- a/src/cmd/go/internal/test/test.go +++ b/src/cmd/go/internal/test/test.go @@ -716,6 +716,12 @@ func runTest(ctx context.Context, cmd *base.Command, args []string) { } } + // A package which only has test files can't be imported + // as a dependency, nor can it be instrumented for coverage. + if len(p.GoFiles)+len(p.CgoFiles) == 0 { + continue + } + // Silently ignore attempts to run coverage on // sync/atomic when using atomic coverage mode. // Atomic coverage mode uses sync/atomic, so |