diff options
| author | Michael Matloob <matloob@golang.org> | 2020-06-30 17:51:52 -0400 |
|---|---|---|
| committer | Michael Matloob <matloob@golang.org> | 2020-08-20 15:21:17 +0000 |
| commit | 3f568625980f6e23a603cfd1cb4fcd2bf5c895d7 (patch) | |
| tree | 8b7e298f273a45bf6ced7e2135ba28ebb68823f3 /src/cmd/go/internal/test/test.go | |
| parent | c57c0212ebf44b7896477177c8e35be79ff3a586 (diff) | |
| download | go-3f568625980f6e23a603cfd1cb4fcd2bf5c895d7.tar.gz go-3f568625980f6e23a603cfd1cb4fcd2bf5c895d7.zip | |
cmd/go: do context propagation for tracing downloads
This change does context propagation (and only context propagation)
necessary to add context to modfetch.Download and pkg.LoadImport.
This was done by adding context to their callers, and then
adding context to all call-sites, and then repeating adding
context to callers of those enclosing functions and their
callers until none were left. In some cases the call graph expansion
was pruned by using context.TODOs.
The next CL will add a span to Download. I kept it out of this
change to avoid making it any larger (and harder to review)
than it needs to be.
Updates #38714
Change-Id: I7a03416e04a14ca71636d96f2c1bda2c4c30d348
Reviewed-on: https://go-review.googlesource.com/c/go/+/249021
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/test/test.go')
| -rw-r--r-- | src/cmd/go/internal/test/test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/cmd/go/internal/test/test.go b/src/cmd/go/internal/test/test.go index 9cef8cf89c..3aee6939d2 100644 --- a/src/cmd/go/internal/test/test.go +++ b/src/cmd/go/internal/test/test.go @@ -702,7 +702,7 @@ func runTest(ctx context.Context, cmd *base.Command, args []string) { } // Select for coverage all dependencies matching the testCoverPaths patterns. - for _, p := range load.TestPackageList(pkgs) { + for _, p := range load.TestPackageList(ctx, pkgs) { haveMatch := false for i := range testCoverPaths { if match[i](p) { |