diff options
| author | Mark Rushakoff <mark.rushakoff@gmail.com> | 2018-11-14 19:34:48 +0000 |
|---|---|---|
| committer | Emmanuel Odeke <emm.odeke@gmail.com> | 2018-11-14 19:59:17 +0000 |
| commit | 529ea7c0de1f9e582280c73031ae870f868e7908 (patch) | |
| tree | 0625a90e07b97974359df7e20ae63f037576d3b4 /src/cmd/go/internal/run/run.go | |
| parent | c92e73b70253f5d88c473a7ad6c5b8d61b2debb7 (diff) | |
| download | go-529ea7c0de1f9e582280c73031ae870f868e7908.tar.gz go-529ea7c0de1f9e582280c73031ae870f868e7908.zip | |
cmd/go: don't panic when go run is passed ... under nonexistent dir
Given a nonexistent directory above a wildcard:
go run ./nonexistent/...
Print this error instead of panicking:
go run: no packages loaded from ./nonexistent/...
Fixes #28696.
Change-Id: Iaa3bc5c78b14ef858d931778e1bc55ca626c5571
GitHub-Last-Rev: bb1a80483ad26c8cf646cf0900d08cfe49aba535
GitHub-Pull-Request: golang/go#28703
Reviewed-on: https://go-review.googlesource.com/c/148821
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Diffstat (limited to 'src/cmd/go/internal/run/run.go')
| -rw-r--r-- | src/cmd/go/internal/run/run.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/cmd/go/internal/run/run.go b/src/cmd/go/internal/run/run.go index 303e6842e7..feccf23b27 100644 --- a/src/cmd/go/internal/run/run.go +++ b/src/cmd/go/internal/run/run.go @@ -78,6 +78,9 @@ func runRun(cmd *base.Command, args []string) { p = load.GoFilesPackage(files) } else if len(args) > 0 && !strings.HasPrefix(args[0], "-") { pkgs := load.PackagesAndErrors(args[:1]) + if len(pkgs) == 0 { + base.Fatalf("go run: no packages loaded from %s", args[0]) + } if len(pkgs) > 1 { var names []string for _, p := range pkgs { |