diff options
author | Dmitri Shuralyov <dmitshur@golang.org> | 2020-11-17 02:04:34 +0000 |
---|---|---|
committer | Jay Conrod <jayconrod@google.com> | 2020-11-17 14:35:27 +0000 |
commit | 3e56bad13b0d287cd77472763fec5e75d9846de6 (patch) | |
tree | 7babb6189f9653311563d7b6bb2b4bc1d8f1a531 /src/cmd/go/internal/modload/modfile.go | |
parent | 0ae3b7cb742c586df9b68d9eac042b32148abf9c (diff) | |
download | go-3e56bad13b0d287cd77472763fec5e75d9846de6.tar.gz go-3e56bad13b0d287cd77472763fec5e75d9846de6.zip |
cmd/go: revert "in 'go get', only load retractions for resolved versions"
This reverts CL 269019.
Reason for revert: The TestScript/mod_gonoproxy test is failing
on linux-386-longtest and linux-amd64-longtest builders.
Change-Id: I7e132fb4fb5a9c00add28e5100a0e96a9250282c
Reviewed-on: https://go-review.googlesource.com/c/go/+/270521
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/modload/modfile.go')
-rw-r--r-- | src/cmd/go/internal/modload/modfile.go | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/cmd/go/internal/modload/modfile.go b/src/cmd/go/internal/modload/modfile.go index e9601c3e7c..7a8963246b 100644 --- a/src/cmd/go/internal/modload/modfile.go +++ b/src/cmd/go/internal/modload/modfile.go @@ -59,7 +59,7 @@ func CheckAllowed(ctx context.Context, m module.Version) error { if err := CheckExclusions(ctx, m); err != nil { return err } - if err := CheckRetractions(ctx, m); err != nil { + if err := checkRetractions(ctx, m); err != nil { return err } return nil @@ -85,9 +85,9 @@ type excludedError struct{} func (e *excludedError) Error() string { return "excluded by go.mod" } func (e *excludedError) Is(err error) bool { return err == ErrDisallowed } -// CheckRetractions returns an error if module m has been retracted by +// checkRetractions returns an error if module m has been retracted by // its author. -func CheckRetractions(ctx context.Context, m module.Version) error { +func checkRetractions(ctx context.Context, m module.Version) error { if m.Version == "" { // Main module, standard library, or file replacement module. // Cannot be retracted. @@ -165,28 +165,28 @@ func CheckRetractions(ctx context.Context, m module.Version) error { } } if isRetracted { - return module.VersionError(m, &ModuleRetractedError{Rationale: rationale}) + return module.VersionError(m, &retractedError{rationale: rationale}) } return nil } var retractCache par.Cache -type ModuleRetractedError struct { - Rationale []string +type retractedError struct { + rationale []string } -func (e *ModuleRetractedError) Error() string { +func (e *retractedError) Error() string { msg := "retracted by module author" - if len(e.Rationale) > 0 { + if len(e.rationale) > 0 { // This is meant to be a short error printed on a terminal, so just // print the first rationale. - msg += ": " + ShortRetractionRationale(e.Rationale[0]) + msg += ": " + ShortRetractionRationale(e.rationale[0]) } return msg } -func (e *ModuleRetractedError) Is(err error) bool { +func (e *retractedError) Is(err error) bool { return err == ErrDisallowed } |