diff options
| author | Jay Conrod <jayconrod@google.com> | 2019-11-21 12:50:14 -0500 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2019-11-21 19:09:24 +0000 |
| commit | 2434869858e75872983038a7dc40df6e942bafba (patch) | |
| tree | 597ef7ab179c7537307b361f7c00cfd1c9d3622c /src/cmd/go/internal/modload/list.go | |
| parent | 37715cce695e96d3d5a8e01f5009517121241330 (diff) | |
| download | go-2434869858e75872983038a7dc40df6e942bafba.tar.gz go-2434869858e75872983038a7dc40df6e942bafba.zip | |
cmd/go: report an error for 'go list -m ...' outside a module
Previously, we just reported an error for "all". Now we report an
error for any pattern that matches modules in the build list. The
build list can only contain the module "command-line-arguments", so
these patterns are not meaningful.
Fixes #35728
Change-Id: Ibc736491ec9164588f9657c09d1b9683b33cf1de
Reviewed-on: https://go-review.googlesource.com/c/go/+/208222
Run-TryBot: Jay Conrod <jayconrod@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/cmd/go/internal/modload/list.go')
| -rw-r--r-- | src/cmd/go/internal/modload/list.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/go/internal/modload/list.go b/src/cmd/go/internal/modload/list.go index c4327276bf..9400793bcb 100644 --- a/src/cmd/go/internal/modload/list.go +++ b/src/cmd/go/internal/modload/list.go @@ -57,8 +57,8 @@ func listModules(args []string, listVersions bool) []*modinfo.ModulePublic { if search.IsRelativePath(arg) { base.Fatalf("go: cannot use relative path %s to specify module", arg) } - if !HasModRoot() && arg == "all" { - base.Fatalf(`go: cannot match "all": working directory is not part of a module`) + if !HasModRoot() && (arg == "all" || strings.Contains(arg, "...")) { + base.Fatalf("go: cannot match %q: working directory is not part of a module", arg) } if i := strings.Index(arg, "@"); i >= 0 { path := arg[:i] |