diff options
| author | Jay Conrod <jayconrod@google.com> | 2020-11-10 15:48:37 -0500 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2020-11-16 21:06:29 +0000 |
| commit | 97700baf8bd5c0fdbfe38eedc80d3c612805cbda (patch) | |
| tree | 3fc43a05446ba8f542fdf31a8270ab93b348bf92 /src/cmd/go/internal/modload/build.go | |
| parent | 38367d098ed4d97539de5e43e03bce985fc56d8e (diff) | |
| download | go-97700baf8bd5c0fdbfe38eedc80d3c612805cbda.tar.gz go-97700baf8bd5c0fdbfe38eedc80d3c612805cbda.zip | |
cmd/go: in 'go get', only load retractions for resolved versions
Previously, 'go get' loaded retractions for every module in the build
list, which took a long time and usually wasn't helpful.
Fixes #42185
Change-Id: I64294585db141106b63ec74aafa0d266b7536ef2
Reviewed-on: https://go-review.googlesource.com/c/go/+/269019
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/modload/build.go')
| -rw-r--r-- | src/cmd/go/internal/modload/build.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/cmd/go/internal/modload/build.go b/src/cmd/go/internal/modload/build.go index b9abb0b93c..b9e344045d 100644 --- a/src/cmd/go/internal/modload/build.go +++ b/src/cmd/go/internal/modload/build.go @@ -123,13 +123,13 @@ func addRetraction(ctx context.Context, m *modinfo.ModulePublic) { return } - err := checkRetractions(ctx, module.Version{Path: m.Path, Version: m.Version}) - var rerr *retractedError + err := CheckRetractions(ctx, module.Version{Path: m.Path, Version: m.Version}) + var rerr *ModuleRetractedError if errors.As(err, &rerr) { - if len(rerr.rationale) == 0 { + if len(rerr.Rationale) == 0 { m.Retracted = []string{"retracted by module author"} } else { - m.Retracted = rerr.rationale + m.Retracted = rerr.Rationale } } else if err != nil && m.Error == nil { m.Error = &modinfo.ModuleError{Err: err.Error()} |