diff options
| author | Jay Conrod <jayconrod@google.com> | 2020-05-20 13:51:53 -0400 |
|---|---|---|
| committer | Jay Conrod <jayconrod@google.com> | 2020-11-17 15:10:45 +0000 |
| commit | 0968d2d599189229145b1000cec55d9df47fbc98 (patch) | |
| tree | 62ef7070d9d2d52cfa58b2e6f92e79a6e5aa71c6 /src/cmd/go/internal/modget/query.go | |
| parent | 3e56bad13b0d287cd77472763fec5e75d9846de6 (diff) | |
| download | go-0968d2d599189229145b1000cec55d9df47fbc98.tar.gz go-0968d2d599189229145b1000cec55d9df47fbc98.zip | |
cmd/go/internal/modget: clarify error for 'go get' without arguments
If the current directory doesn't contain a package, 'go get' will say
that without additional detail.
If there were no arguments, errors will start with "go get:" instead
of "go get .:".
Fixes #39080
Change-Id: I47366f2a27bce17bd8b79344ad15b8b934a888c9
Reviewed-on: https://go-review.googlesource.com/c/go/+/234681
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Jay Conrod <jayconrod@google.com>
Diffstat (limited to 'src/cmd/go/internal/modget/query.go')
| -rw-r--r-- | src/cmd/go/internal/modget/query.go | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/cmd/go/internal/modget/query.go b/src/cmd/go/internal/modget/query.go index 53b60cc71a..20eb0b6364 100644 --- a/src/cmd/go/internal/modget/query.go +++ b/src/cmd/go/internal/modget/query.go @@ -295,7 +295,11 @@ func reportError(q *query, err error) { } } - base.Errorf("go get %s: %s", q, errStr) + if qs := q.String(); qs != "" { + base.Errorf("go get %s: %s", qs, errStr) + } else { + base.Errorf("go get: %s", errStr) + } } func reportConflict(pq *query, m module.Version, conflict versionReason) { |