diff options
author | Jay Conrod <jayconrod@google.com> | 2020-09-18 08:33:44 -0400 |
---|---|---|
committer | Jay Conrod <jayconrod@google.com> | 2020-09-18 13:37:22 +0000 |
commit | bf9800c7931da96e2ddc8363955f43581265b95c (patch) | |
tree | f73d5f81c8dd81b54858c630d2017f62b3c96760 /src/cmd/go/internal/load/pkg.go | |
parent | c47ba5fbfb86edbf49450b8b7b173ab2d188f41f (diff) | |
download | go-bf9800c7931da96e2ddc8363955f43581265b95c.tar.gz go-bf9800c7931da96e2ddc8363955f43581265b95c.zip |
cmd/go: fix review comments in load, modload
Follow-up to CL 255719, fixing review comments.
Change-Id: I26d3cc622496c3902c6924cf2b746c50705c4d50
Reviewed-on: https://go-review.googlesource.com/c/go/+/255937
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Diffstat (limited to 'src/cmd/go/internal/load/pkg.go')
-rw-r--r-- | src/cmd/go/internal/load/pkg.go | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/cmd/go/internal/load/pkg.go b/src/cmd/go/internal/load/pkg.go index d06e65737d..077fdf25d3 100644 --- a/src/cmd/go/internal/load/pkg.go +++ b/src/cmd/go/internal/load/pkg.go @@ -420,13 +420,16 @@ type ImportPathError interface { ImportPath() string } +var ( + _ ImportPathError = (*importError)(nil) + _ ImportPathError = (*modload.ImportMissingError)(nil) +) + type importError struct { importPath string err error // created with fmt.Errorf } -var _ ImportPathError = (*importError)(nil) - func ImportErrorf(path, format string, args ...interface{}) ImportPathError { err := &importError{importPath: path, err: fmt.Errorf(format, args...)} if errStr := err.Error(); !strings.Contains(errStr, path) { @@ -882,7 +885,7 @@ var preloadWorkerCount = runtime.GOMAXPROCS(0) // because of global mutable state that cannot safely be read and written // concurrently. In particular, packageDataCache may be cleared by "go get" // in GOPATH mode, and modload.loaded (accessed via modload.Lookup) may be -// modified by modload.ImportPaths (modload.ImportPaths). +// modified by modload.ImportPaths. type preload struct { cancel chan struct{} sema chan struct{} |